Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2628093003: [serializer] change internal field callbacks to take data pointer. (Closed)

Created:
3 years, 11 months ago by Yang
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] change internal field callbacks to take data pointer. R=jochen@chromium.org, peria@chromium.org BUG=chromium:617892 Review-Url: https://codereview.chromium.org/2628093003 Cr-Commit-Position: refs/heads/master@{#42268} Committed: https://chromium.googlesource.com/v8/v8/+/9cd0de73dc920f7c75cb0f3aa55405701d43cae3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -45 lines) Patch
M include/v8.h View 3 chunks +28 lines, -10 lines 0 comments Download
M src/api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M src/debug/debug.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/snapshot/deserializer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/snapshot/partial-serializer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-serialize.cc View 14 chunks +55 lines, -24 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
3 years, 11 months ago (2017-01-12 11:28:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-12 11:34:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628093003/1
3 years, 11 months ago (2017-01-12 11:55:54 UTC) #4
peria
LGTM
3 years, 11 months ago (2017-01-12 11:59:20 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 12:26:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9cd0de73dc920f7c75cb0f3aa55405701d4...

Powered by Google App Engine
This is Rietveld 408576698