Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2628093002: [i18n] renderer plugins change i18n-content to $i18n{} (Closed)

Created:
3 years, 11 months ago by dschuyler
Modified:
3 years, 11 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] renderer plugins change i18n-content to $i18n{} This is a mechanical change to convert i18n-content to $i18n{} tags. BUG=677338 Review-Url: https://codereview.chromium.org/2628093002 Cr-Commit-Position: refs/heads/master@{#443064} Committed: https://chromium.googlesource.com/chromium/src/+/db4968cfc7814d6fd5df1573d6213fbbf3a872ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/renderer/resources/plugins/blocked_plugin.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/plugins/disabled_plugin.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/plugins/prefer_html_plugin.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
3 years, 11 months ago (2017-01-11 22:29:41 UTC) #4
tommycli
LGTM except bug number looks incorrect.
3 years, 11 months ago (2017-01-11 22:33:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628093002/1
3 years, 11 months ago (2017-01-11 23:41:10 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:59:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db4968cfc7814d6fd5df1573d621...

Powered by Google App Engine
This is Rietveld 408576698