Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2628053004:
[wasm] JS-APIs: more WebAssembly.compile tests (Closed)
|
Created:
3 years, 11 months ago by Mircea Trofin Modified:
3 years, 11 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] JS-APIs: more WebAssembly.compile tests
enabled TODO-ed compile tests
BUG=v8:5833
Review-Url: https://codereview.chromium.org/2628053004
Cr-Commit-Position: refs/heads/master@{#42293}
Committed: https://chromium.googlesource.com/v8/v8/+/7c7434085ef3f26a3d43e059bee369e61347fe6d
Patch Set 1 #Patch Set 2 : fixed failure cases #Patch Set 3 : rebase #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== [wasm] JS-APIs: more WebAssembly.compile tests enabled TODO-ed compile tests BUG= ========== to ========== [wasm] JS-APIs: more WebAssembly.compile tests enabled TODO-ed compile tests BUG= ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org, rossberg@chromium.org, titzer@chromium.org
lgtm
On 2017/01/12 17:23:35, titzer wrote: > lgtm PTAL, because we actually had a bug.
Description was changed from ========== [wasm] JS-APIs: more WebAssembly.compile tests enabled TODO-ed compile tests BUG= ========== to ========== [wasm] JS-APIs: more WebAssembly.compile tests enabled TODO-ed compile tests BUG=v8:5833 ==========
lgtm
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for src/wasm/wasm-js.cc:
While running git apply --index -p1;
error: patch failed: src/wasm/wasm-js.cc:70
error: src/wasm/wasm-js.cc: patch does not apply
Patch: src/wasm/wasm-js.cc
Index: src/wasm/wasm-js.cc
diff --git a/src/wasm/wasm-js.cc b/src/wasm/wasm-js.cc
index
8a4b06d9253a7451a104a8486f45377bc185bbd5..561bbe31fd6caab8138c5706abf597c349ef6c41
100644
--- a/src/wasm/wasm-js.cc
+++ b/src/wasm/wasm-js.cc
@@ -56,9 +56,6 @@ RawBuffer GetRawBufferSource(
start = reinterpret_cast<const byte*>(contents.Data());
end = start + contents.ByteLength();
- if (start == nullptr || end == start) {
- thrower->CompileError("ArrayBuffer argument is empty");
- }
} else if (source->IsTypedArray()) {
// A TypedArray was passed.
Local<TypedArray> array = Local<TypedArray>::Cast(source);
@@ -70,13 +67,12 @@ RawBuffer GetRawBufferSource(
reinterpret_cast<const byte*>(contents.Data()) + array->ByteOffset();
end = start + array->ByteLength();
- if (start == nullptr || end == start) {
- thrower->TypeError("ArrayBuffer argument is empty");
- }
} else {
thrower->TypeError("Argument 0 must be an ArrayBuffer or Uint8Array");
}
-
+ if (start == nullptr || end == start) {
+ thrower->CompileError("BufferSource argument is empty");
+ }
return {start, end};
}
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2628053004/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org Link to the patchset: https://codereview.chromium.org/2628053004/#ps60001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484254847124760,
"parent_rev": "8194ff053f35cebe1d731735e3119ae529c1d33e", "commit_rev":
"7c7434085ef3f26a3d43e059bee369e61347fe6d"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] JS-APIs: more WebAssembly.compile tests enabled TODO-ed compile tests BUG=v8:5833 ========== to ========== [wasm] JS-APIs: more WebAssembly.compile tests enabled TODO-ed compile tests BUG=v8:5833 Review-Url: https://codereview.chromium.org/2628053004 Cr-Commit-Position: refs/heads/master@{#42293} Committed: https://chromium.googlesource.com/v8/v8/+/7c7434085ef3f26a3d43e059bee369e6134... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/v8/v8/+/7c7434085ef3f26a3d43e059bee369e6134... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
