Fix simarm64 bugs on Windows.

Fix simarm64 bugs on Windows.

This fixes build errors and crashes when building simarm64 on Windows:
1. __int128 is not supported by Visual Studio. Use Multiply128 instead on Windows.
2. UL is 32-bit - replace with ULL when doing 64-bit math.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/050d2e3df932daf8a48989aff9a061a4e127f87c

[Florian Schneider, 2017-01-13 20:14:21]

fschneider@google.com changed reviewers:
+ zra@google.com

[zra, 2017-01-13 20:21:07]

lgtm with nits

Good find!

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64.cc
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2660: // Visual Studio does not support __int128
End comment with '.'.

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2667: #endif
#endif  // defined(TARGET_OS_WINDOWS)

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2675: // Visual Studio does not support __int128
ditto

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2682: #endif
ditto

[Florian Schneider, 2017-01-13 20:24:15]

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64.cc
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2660: // Visual Studio does not support __int128
On 2017/01/13 20:21:07, zra wrote:
> End comment with '.'.

Done.

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2667: #endif
On 2017/01/13 20:21:07, zra wrote:
> #endif  // defined(TARGET_OS_WINDOWS)

Done.

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2675: // Visual Studio does not support __int128
On 2017/01/13 20:21:07, zra wrote:
> ditto

Done.

https://codereview.chromium.org/2628043006/diff/1/runtime/vm/simulator_arm64....
runtime/vm/simulator_arm64.cc:2682: #endif
On 2017/01/13 20:21:07, zra wrote:
> ditto

Done.

[Florian Schneider, 2017-01-13 20:30:16]

Description was changed from

==========
Fix simarm64 bugs on Windows.

This fixes build errors and crashes when building simarm64 on Windows:
1. __int128 is not supported by Visual Studio. Use Multiply128 instead on
Windows.
2. UL is 32-bit - replace with ULL when doing 64-bit math.
==========

to

==========
Fix simarm64 bugs on Windows.

This fixes build errors and crashes when building simarm64 on Windows:
1. __int128 is not supported by Visual Studio. Use Multiply128 instead on
Windows.
2. UL is 32-bit - replace with ULL when doing 64-bit math.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/050d2e3df932daf8a48989aff9a061a4e127f87c
==========

[Florian Schneider, 2017-01-13 20:30:18]

Committed patchset #2 (id:20001) manually as
050d2e3df932daf8a48989aff9a061a4e127f87c (presubmit successful).