Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 2628033002: [Android]Fix a regression where native pages hide tab strip on tablet (Closed)

Created:
3 years, 11 months ago by Ian Wen
Modified:
3 years, 11 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android]Fix a regression where native pages hide tab strip on tablet CompositorViewHolder should add views with their original layout params, rather than creating a new one every time. BUG=679998 Review-Url: https://codereview.chromium.org/2628033002 Cr-Commit-Position: refs/heads/master@{#443016} Committed: https://chromium.googlesource.com/chromium/src/+/3a6eca3ccd3baaba2e1690ed02757d6281123c44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Ian Wen
PTAL :)
3 years, 11 months ago (2017-01-11 19:23:26 UTC) #2
gone
lgtm
3 years, 11 months ago (2017-01-11 20:06:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2628033002/1
3 years, 11 months ago (2017-01-11 21:04:51 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:25:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3a6eca3ccd3baaba2e1690ed0275...

Powered by Google App Engine
This is Rietveld 408576698