X87: [TypeFeedbackVector] Root literal arrays in function literals slots.

X87: [TypeFeedbackVector] Root literal arrays in function literals slots.

  port b8294aaa978e972978b8d82cedf63befad5d7af1 (r42264)

  original commit message:
  Literal arrays and feedback vectors for a function can be garbage
  collected if we don't have a rooted closure for the function, which
  happens often. It's expensive to come back from this (recreating
  boilerplates and gathering feedback again), and the cost is
  disproportionate if the function was inlined into optimized code.

  To guard against losing these arrays when we need them, we'll now
  create literal arrays when creating the feedback vector for the outer
  closure, and root them strongly in that vector.

BUG=

Review-Url: https://codereview.chromium.org/2627973007
Cr-Commit-Position: refs/heads/master@{#42351}
Committed: https://chromium.googlesource.com/v8/v8/+/f9677ecf5ff55165c8b11b34ae8d9e75ba504990

[zhengxing.li, 2017-01-13 08:44:06]

zhengxing.li@intel.com changed reviewers:
+ chunyang.dai@intel.com, mvstanton@chromium.org

[zhengxing.li, 2017-01-13 08:44:06]

PTAL, thanks!

[chunyang.dai, 2017-01-16 02:32:40]

On 2017/01/13 08:44:06, zhengxing.li wrote:
> PTAL, thanks!

LGTM.

thanks

[zhengxing.li, 2017-01-16 02:34:06]

The CQ bit was checked by zhengxing.li@intel.com

[commit-bot: I haz the power, 2017-01-16 02:34:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 02:54:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484534046039240, "parent_rev":
"7d42244a7ea0a807e8e4fc626b58c233c1c4f2dc", "commit_rev":
"f9677ecf5ff55165c8b11b34ae8d9e75ba504990"}

[commit-bot: I haz the power, 2017-01-16 02:54:13]

Description was changed from

==========
X87: [TypeFeedbackVector] Root literal arrays in function literals slots.

  port b8294aaa978e972978b8d82cedf63befad5d7af1 (r42264)

  original commit message:
  Literal arrays and feedback vectors for a function can be garbage
  collected if we don't have a rooted closure for the function, which
  happens often. It's expensive to come back from this (recreating
  boilerplates and gathering feedback again), and the cost is
  disproportionate if the function was inlined into optimized code.

  To guard against losing these arrays when we need them, we'll now
  create literal arrays when creating the feedback vector for the outer
  closure, and root them strongly in that vector.

BUG=
==========

to

==========
X87: [TypeFeedbackVector] Root literal arrays in function literals slots.

  port b8294aaa978e972978b8d82cedf63befad5d7af1 (r42264)

  original commit message:
  Literal arrays and feedback vectors for a function can be garbage
  collected if we don't have a rooted closure for the function, which
  happens often. It's expensive to come back from this (recreating
  boilerplates and gathering feedback again), and the cost is
  disproportionate if the function was inlined into optimized code.

  To guard against losing these arrays when we need them, we'll now
  create literal arrays when creating the feedback vector for the outer
  closure, and root them strongly in that vector.

BUG=

Review-Url: https://codereview.chromium.org/2627973007
Cr-Commit-Position: refs/heads/master@{#42351}
Committed:
https://chromium.googlesource.com/v8/v8/+/f9677ecf5ff55165c8b11b34ae8d9e75ba5...
==========

[commit-bot: I haz the power, 2017-01-16 02:54:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f9677ecf5ff55165c8b11b34ae8d9e75ba5...