Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2627973006: ozone: Create GbmBuffers from fourcc formats and gbm flags. (Closed)

Created:
3 years, 11 months ago by Daniele Castagna
Modified:
3 years, 11 months ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

ozone: Create GbmBuffers from fourcc formats and gbm flags. This CL changes the interface of GbmBuffer to use fourcc formats and gbm flags instead of gfx::Buffer{Format,Usage}. In this way we can create modeset buffers that can be mapped and can be scanned out without the need to add a new gfx::BufferUsage. BUG=chrome-os-partner:56407, 680510 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2533163002 Cr-Commit-Position: refs/heads/master@{#435368} (cherry picked from commit 2be041a887dffe27d886225be13d69160115dd12) Review-Url: https://codereview.chromium.org/2627973006 Cr-Commit-Position: refs/branch-heads/2924@{#749} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/bcbdc59ce43202ec03929bd376bb8a9745c63aab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -81 lines) Patch
M ui/ozone/platform/drm/gpu/drm_overlay_validator.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_overlay_validator_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 5 chunks +23 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 2 chunks +9 lines, -9 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 11 chunks +29 lines, -44 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_dumb_buffer_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/scanout_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627973006/1
3 years, 11 months ago (2017-01-12 23:46:34 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-12 23:46:35 UTC) #5
reveman
lgtm
3 years, 11 months ago (2017-01-12 23:53:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627973006/1
3 years, 11 months ago (2017-01-12 23:55:31 UTC) #9
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-12 23:55:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627973006/1
3 years, 11 months ago (2017-01-12 23:56:59 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 00:06:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcbdc59ce43202ec03929bd376bb...

Powered by Google App Engine
This is Rietveld 408576698