[Payments] Add support of basic-card Android payment apps

Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithBasicCard:
     https://drive.google.com/open?id=0B3ISiXgGE1MNUGg0VHNjdTlkaDg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
Review-Url: https://codereview.chromium.org/2627953006
Cr-Commit-Position: refs/heads/master@{#443592}
Committed: https://chromium.googlesource.com/chromium/src/+/7c1f35f2253344df40c0355fc370797cc095dc4f

[gogerald1, 2017-01-13 00:34:16]

Description was changed from

==========
Support basic-card Android payment app


draft

BUG=
==========

to

==========
Add support of basic-card Android payment app

BUG=
==========

[gogerald1, 2017-01-13 00:36:24]

Description was changed from

==========
Add support of basic-card Android payment app

BUG=
==========

to

==========
Add support of basic-card Android payment app

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/bob/.
  4) Click [Buy] button.

BUG=680663
==========

[gogerald1, 2017-01-13 00:36:40]

Description was changed from

==========
Add support of basic-card Android payment app

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/bob/.
  4) Click [Buy] button.

BUG=680663
==========

to

==========
Add support of basic-card Android payment app

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

[gogerald1, 2017-01-13 00:37:19]

Description was changed from

==========
Add support of basic-card Android payment app

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

to

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

[gogerald1, 2017-01-13 00:48:42]

Patchset #1 (id:1) has been deleted

[gogerald1, 2017-01-13 00:58:29]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2017-01-13 01:01:28]

Description was changed from

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPay:
     https://drive.google.com/open?id=0B9_TYWUgXNVFLXpRRkthd1lRbjg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

to

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithBasicCard:
    
https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNUGg0VHNjdTlkaDg/vie...
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

[gogerald1, 2017-01-13 01:03:03]

Description was changed from

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithBasicCard:
    
https://drive.google.com/a/google.com/file/d/0B3ISiXgGE1MNUGg0VHNjdTlkaDg/vie...
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

to

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithBasicCard:
     https://drive.google.com/open?id=0B3ISiXgGE1MNUGg0VHNjdTlkaDg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

[gogerald1, 2017-01-13 01:03:12]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2017-01-13 01:03:50]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2017-01-13 01:03:51]

Hi rouslan@, PTAL,

[commit-bot: I haz the power, 2017-01-13 01:05:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:40:51]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-01-13 14:41:03]

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:39:
public static final String BASIC_CARD_PAYMENT_METHOD = "basic-card";
public constants need javadoc.

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:132:
if (methodName.equals(BASIC_CARD_PAYMENT_METHOD)) {
The spec has changed to pass the full list of mMethodNames to the app. No need
to make that particular change in this patch, but let's continue using
ACTOIN_PAY unconditionally. Bo the ACTION_PAY and ACTION_PAY_BASIC_CARD should
be served by the same activity, so it makes no functional difference which one
we use.

"basic-card" also expects EXTRA_DATA, by the way.

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
(right):

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:68:
setIsReadyToPayService(installedApps, pm, new
Intent(ACTION_IS_READY_TO_PAY_BASIC_CARD));
I now realize that there's no need to have
"org.chromium.intent.action.IS_READY_TO_PAY_BASIC_CARD", because the same
service responds to both intents and Chrome sends |methodNames| to the queried
service. I'll update the spec and you can remove
"org.chromium.intent.action.IS_READY_TO_PAY_BASIC_CARD".

[gogerald1, 2017-01-13 15:23:16]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 15:23:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-01-13 15:24:11]

ptal,

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java
(right):

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:39:
public static final String BASIC_CARD_PAYMENT_METHOD = "basic-card";
On 2017/01/13 14:41:03, rouslan wrote:
> public constants need javadoc.

Done.

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentApp.java:132:
if (methodName.equals(BASIC_CARD_PAYMENT_METHOD)) {
On 2017/01/13 14:41:03, rouslan wrote:
> The spec has changed to pass the full list of mMethodNames to the app. No need
> to make that particular change in this patch, but let's continue using
> ACTOIN_PAY unconditionally. Bo the ACTION_PAY and ACTION_PAY_BASIC_CARD should
> be served by the same activity, so it makes no functional difference which one
> we use.
> 
> "basic-card" also expects EXTRA_DATA, by the way.

Done.

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
(right):

https://codereview.chromium.org/2627953006/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:68:
setIsReadyToPayService(installedApps, pm, new
Intent(ACTION_IS_READY_TO_PAY_BASIC_CARD));
On 2017/01/13 14:41:03, rouslan wrote:
> I now realize that there's no need to have
> "org.chromium.intent.action.IS_READY_TO_PAY_BASIC_CARD", because the same
> service responds to both intents and Chrome sends |methodNames| to the queried
> service. I'll update the spec and you can remove
> "org.chromium.intent.action.IS_READY_TO_PAY_BASIC_CARD".

Done.

[please use gerrit instead, 2017-01-13 15:31:08]

lgtm % nit

https://codereview.chromium.org/2627953006/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
(right):

https://codereview.chromium.org/2627953006/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:33:
* https://w3c.github.io/webpayments-methods-card/#method-id.
nit: No period after a URL on its own line. This allows faster copy-paste.

[commit-bot: I haz the power, 2017-01-13 15:56:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 15:56:23]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-01-13 16:43:38]

https://codereview.chromium.org/2627953006/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java
(right):

https://codereview.chromium.org/2627953006/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/AndroidPaymentAppFactory.java:33:
* https://w3c.github.io/webpayments-methods-card/#method-id.
On 2017/01/13 15:31:08, rouslan wrote:
> nit: No period after a URL on its own line. This allows faster copy-paste.

Done.

[gogerald1, 2017-01-13 16:43:44]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2017-01-13 16:43:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2627953006/#ps80001
(title: "fix nit")

[commit-bot: I haz the power, 2017-01-13 16:44:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 17:19:44]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484325824267480,
"parent_rev": "12bd970214af9f7a2716037569df8261f565453a", "commit_rev":
"7c1f35f2253344df40c0355fc370797cc095dc4f"}

[commit-bot: I haz the power, 2017-01-13 17:20:14]

Description was changed from

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithBasicCard:
     https://drive.google.com/open?id=0B3ISiXgGE1MNUGg0VHNjdTlkaDg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663
==========

to

==========
Add support of basic-card Android payment apps

The feature is disabled by default. It can be enabled via a flag:

  chrome://flags/#android-payment-apps

To test the new functionality:

  1) Install BobPayWithBasicCard:
     https://drive.google.com/open?id=0B3ISiXgGE1MNUGg0VHNjdTlkaDg
  2) Enable chrome://flags/#android-payment-apps.
  3) Open https://rsolomakhin.github.io/pr/.
  4) Click [Buy] button.

BUG=680663

Review-Url: https://codereview.chromium.org/2627953006
Cr-Commit-Position: refs/heads/master@{#443592}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c1f35f2253344df40c0355fc370...
==========

[commit-bot: I haz the power, 2017-01-13 17:20:15]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/7c1f35f2253344df40c0355fc370...