[wasm] The interpreter should not grow memory beyond module->mem_max_pages.

[wasm] The interpreter should not grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
TEST=cctest/test-run-wasm-interpreter/GrowMemory

Review-Url: https://codereview.chromium.org/2627943002
Cr-Commit-Position: refs/heads/master@{#42240}
Committed: https://chromium.googlesource.com/v8/v8/+/57c20f0b72145c849c6880b5aa04b729f0fa55de

[ahaas, 2017-01-11 15:20:40]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 15:20:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-01-11 15:21:56]

Description was changed from

==========
[wasm] The interpreter should grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
==========

to

==========
[wasm] The interpreter should grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
TEST=cctest/test-run-wasm-interpreter/GrowMemory
==========

[titzer, 2017-01-11 15:27:06]

lgtm with comment

https://codereview.chromium.org/2627943002/diff/1/src/wasm/wasm-interpreter.cc
File src/wasm/wasm-interpreter.cc (right):

https://codereview.chromium.org/2627943002/diff/1/src/wasm/wasm-interpreter.c...
src/wasm/wasm-interpreter.cc:684: if (new_size > wasm::kV8MaxWasmMemoryPages *
wasm::WasmModule::kPageSize ||
Do you want to check both of these the same way (e.g. in page units)?

[ahaas, 2017-01-11 15:36:50]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[ahaas, 2017-01-11 15:36:53]

https://codereview.chromium.org/2627943002/diff/1/src/wasm/wasm-interpreter.cc
File src/wasm/wasm-interpreter.cc (right):

https://codereview.chromium.org/2627943002/diff/1/src/wasm/wasm-interpreter.c...
src/wasm/wasm-interpreter.cc:684: if (new_size > wasm::kV8MaxWasmMemoryPages *
wasm::WasmModule::kPageSize ||
On 2017/01/11 at 15:27:06, titzer wrote:
> Do you want to check both of these the same way (e.g. in page units)?

Done.

[commit-bot: I haz the power, 2017-01-11 15:36:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-11 15:37:38]

On 2017/01/11 15:36:53, ahaas wrote:
> https://codereview.chromium.org/2627943002/diff/1/src/wasm/wasm-interpreter.cc
> File src/wasm/wasm-interpreter.cc (right):
> 
>
https://codereview.chromium.org/2627943002/diff/1/src/wasm/wasm-interpreter.c...
> src/wasm/wasm-interpreter.cc:684: if (new_size > wasm::kV8MaxWasmMemoryPages *
> wasm::WasmModule::kPageSize ||
> On 2017/01/11 at 15:27:06, titzer wrote:
> > Do you want to check both of these the same way (e.g. in page units)?
> 
> Done.

BTW can you update the CL description? I think you are missing the word "not".

[ahaas, 2017-01-11 15:41:50]

Description was changed from

==========
[wasm] The interpreter should grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
TEST=cctest/test-run-wasm-interpreter/GrowMemory
==========

to

==========
[wasm] The interpreter should not grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
TEST=cctest/test-run-wasm-interpreter/GrowMemory
==========

[commit-bot: I haz the power, 2017-01-11 16:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:02:55]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-11 17:22:18]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2017-01-11 17:22:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 17:24:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484155338298490,
"parent_rev": "7a3366fbcd556ba6e5a714b34e9ae2085446d987", "commit_rev":
"57c20f0b72145c849c6880b5aa04b729f0fa55de"}

[commit-bot: I haz the power, 2017-01-11 17:24:05]

Description was changed from

==========
[wasm] The interpreter should not grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
TEST=cctest/test-run-wasm-interpreter/GrowMemory
==========

to

==========
[wasm] The interpreter should not grow memory beyond module->mem_max_pages.

R=titzer@chromium.org
BUG=chromium:679352
TEST=cctest/test-run-wasm-interpreter/GrowMemory

Review-Url: https://codereview.chromium.org/2627943002
Cr-Commit-Position: refs/heads/master@{#42240}
Committed:
https://chromium.googlesource.com/v8/v8/+/57c20f0b72145c849c6880b5aa04b729f0f...
==========

[commit-bot: I haz the power, 2017-01-11 17:24:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/57c20f0b72145c849c6880b5aa04b729f0f...