[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=chromium:575167
Review-Url: https://codereview.chromium.org/2627923002
Cr-Commit-Position: refs/heads/master@{#443192}
Committed: https://chromium.googlesource.com/chromium/src/+/76dd8760da6ae9c0993674c7d7d6045f0562824e

[titzer, 2017-01-11 14:48:10]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[titzer, 2017-01-11 14:48:29]

Description was changed from

==========
[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=
==========

to

==========
[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=
==========

[titzer, 2017-01-11 14:48:30]

titzer@chromium.org changed reviewers:
+ rossberg@chromium.org

[commit-bot: I haz the power, 2017-01-11 14:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-11 14:49:35]

On 2017/01/11 14:48:30, titzer wrote:
> mailto:titzer@chromium.org changed reviewers:
> + mailto:rossberg@chromium.org

PTAL. Several layout tests (e.g. here:
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_6...)
check which APIs are exposed by comparing to a known Whitelist, and fail if
WebAssembly is provided as a property on the global object by the JS engine.

[titzer, 2017-01-11 14:50:12]

Description was changed from

==========
[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=
==========

to

==========
[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=chromium:575167
==========

[rossberg, 2017-01-11 15:00:17]

lgtm

[jochen (gone - plz use gerrit), 2017-01-11 15:14:10]

lgtm with comment

https://codereview.chromium.org/2627923002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js
(right):

https://codereview.chromium.org/2627923002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js:89:
'WebAssembly',
please move that up to between WeakSet and decodeURI

[titzer, 2017-01-11 15:17:31]

On 2017/01/11 15:14:10, jochen wrote:
> lgtm with comment
> 
>
https://codereview.chromium.org/2627923002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js
> (right):
> 
>
https://codereview.chromium.org/2627923002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js:89:
> 'WebAssembly',
> please move that up to between WeakSet and decodeURI

Done.

[titzer, 2017-01-11 15:17:42]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 15:18:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:40:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[titzer, 2017-01-11 17:52:36]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-11 17:55:28]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2017-01-11 17:55:52]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 17:56:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2017-01-11 18:03:59]

On 2017/01/11 15:17:31, titzer wrote:
> On 2017/01/11 15:14:10, jochen wrote:
> > lgtm with comment
> > 
> >
>
https://codereview.chromium.org/2627923002/diff/1/third_party/WebKit/LayoutTe...
> > File
> >
>
third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js
> > (right):
> > 
> >
>
https://codereview.chromium.org/2627923002/diff/1/third_party/WebKit/LayoutTe...
> >
>
third_party/WebKit/LayoutTests/webexposed/resources/global-interface-listing.js:89:
> > 'WebAssembly',
> > please move that up to between WeakSet and decodeURI
> 
> Done.

Please take another look. I found two more spots that had the same problem, and
the additional line has meant the expectation file also had to be updated.

[jochen (gone - plz use gerrit), 2017-01-11 18:06:54]

lgtm

[titzer, 2017-01-11 19:02:12]

The CQ bit was unchecked by titzer@chromium.org

[titzer, 2017-01-11 19:02:20]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-11 19:02:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/2627923002/#ps80001
(title: "Found another expectation file")

[commit-bot: I haz the power, 2017-01-11 19:03:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 19:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:57:53]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[titzer, 2017-01-12 08:56:59]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-01-12 08:57:00]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
rossberg@chromium.org
Link to the patchset: https://codereview.chromium.org/2627923002/#ps100001
(title: "Found another expectations file.")

[commit-bot: I haz the power, 2017-01-12 08:57:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 09:52:58]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484211419788970,
"parent_rev": "50e9d9c4ee8bd08fa12ed7e8715b42495a17e0b4", "commit_rev":
"76dd8760da6ae9c0993674c7d7d6045f0562824e"}

[commit-bot: I haz the power, 2017-01-12 09:53:35]

Description was changed from

==========
[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=chromium:575167
==========

to

==========
[layout-tests] Whitelist WebAssembly as a JavaScript-provided API.

R=jochen@chromium.org
BUG=chromium:575167

Review-Url: https://codereview.chromium.org/2627923002
Cr-Commit-Position: refs/heads/master@{#443192}
Committed:
https://chromium.googlesource.com/chromium/src/+/76dd8760da6ae9c0993674c7d7d6...
==========

[commit-bot: I haz the power, 2017-01-12 09:53:39]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/76dd8760da6ae9c0993674c7d7d6...