Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 2627903002: Add missing includes. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
Bernhard Bauer, gab, Jana, hubbe
CC:
chromium-reviews, msramek+watch_chromium.org, imcheng+watch_chromium.org, ntp-dev+reviews_chromium.org, jasonroberts+watch_google.com, xjz+watch_chromium.org, avayvod+watch_chromium.org, cbentzel+watch_chromium.org, feature-media-reviews_chromium.org, noyau+watch_chromium.org, markusheintz_, isheriff+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : self-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/browsing_data/cache_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/ntp_snippets/features.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/test/receiver.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M net/android/network_change_notifier_delegate_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_session_pool.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-11 13:53:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627903002/20001
3 years, 11 months ago (2017-01-11 13:54:31 UTC) #5
Bernhard Bauer
LGTM, but I don't think TBR is appropriate here without at least getting some approval ...
3 years, 11 months ago (2017-01-11 13:56:23 UTC) #6
fdoray
gab@: PTAL
3 years, 11 months ago (2017-01-11 14:07:04 UTC) #9
hubbe
media/cast LGTM
3 years, 11 months ago (2017-01-11 18:43:16 UTC) #10
gab
lgtm
3 years, 11 months ago (2017-01-11 19:07:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627903002/20001
3 years, 11 months ago (2017-01-11 19:08:59 UTC) #13
Jana
lgtm
3 years, 11 months ago (2017-01-11 20:08:53 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 22:42:29 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e41b7310e119afeb16eb76a10af9...

Powered by Google App Engine
This is Rietveld 408576698