Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h

Issue 2627853002: Show the search geolocation disclosure from geolocation API use. (Closed)
Patch Set: Feedback and rebase (sorry) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h
diff --git a/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h b/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h
index 771e6228ff03f288cb4f83472f677aed2ac28b17..c67e7195d184fbc04ce004aa87c3e91842941f93 100644
--- a/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h
+++ b/chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h
@@ -30,6 +30,8 @@ class SearchGeolocationDisclosureTabHelper
void NavigationEntryCommitted(
const content::LoadCommittedDetails& load_details) override;
+ void MaybeShowDisclosureForAPIUsage(const GURL& gurl);
+
static void ResetDisclosure(Profile* profile);
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
@@ -42,7 +44,8 @@ class SearchGeolocationDisclosureTabHelper
friend class content::WebContentsUserData<
SearchGeolocationDisclosureTabHelper>;
- void MaybeShowDefaultSearchGeolocationDisclosure(const GURL& gurl);
+ void MaybeShowDisclosureForOmnibox(const GURL& gurl);
+ void ShowDisclosureIfRulesPermit(const GURL& gurl);
bool ShouldShowDisclosureForUrl(const GURL& gurl);

Powered by Google App Engine
This is Rietveld 408576698