Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Side by Side Diff: chrome/browser/android/search_geolocation/search_geolocation_disclosure_tab_helper.h

Issue 2627853002: Show the search geolocation disclosure from geolocation API use. (Closed)
Patch Set: Feedback and rebase (sorry) Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_SEARCH_GEOLOCATION_DISCLOSURE_ TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_SEARCH_GEOLOCATION_DISCLOSURE_ TAB_HELPER_H_
6 #define CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_SEARCH_GEOLOCATION_DISCLOSURE_ TAB_HELPER_H_ 6 #define CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_SEARCH_GEOLOCATION_DISCLOSURE_ TAB_HELPER_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 12 matching lines...) Expand all
23 : public content::WebContentsObserver, 23 : public content::WebContentsObserver,
24 public content::WebContentsUserData< 24 public content::WebContentsUserData<
25 SearchGeolocationDisclosureTabHelper> { 25 SearchGeolocationDisclosureTabHelper> {
26 public: 26 public:
27 ~SearchGeolocationDisclosureTabHelper() override; 27 ~SearchGeolocationDisclosureTabHelper() override;
28 28
29 // content::WebContentsObserver overrides. 29 // content::WebContentsObserver overrides.
30 void NavigationEntryCommitted( 30 void NavigationEntryCommitted(
31 const content::LoadCommittedDetails& load_details) override; 31 const content::LoadCommittedDetails& load_details) override;
32 32
33 void MaybeShowDisclosureForAPIUsage(const GURL& gurl);
34
33 static void ResetDisclosure(Profile* profile); 35 static void ResetDisclosure(Profile* profile);
34 36
35 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry); 37 static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
36 38
37 // Registers native methods. 39 // Registers native methods.
38 static bool Register(JNIEnv* env); 40 static bool Register(JNIEnv* env);
39 41
40 private: 42 private:
41 explicit SearchGeolocationDisclosureTabHelper(content::WebContents* contents); 43 explicit SearchGeolocationDisclosureTabHelper(content::WebContents* contents);
42 friend class content::WebContentsUserData< 44 friend class content::WebContentsUserData<
43 SearchGeolocationDisclosureTabHelper>; 45 SearchGeolocationDisclosureTabHelper>;
44 46
45 void MaybeShowDefaultSearchGeolocationDisclosure(const GURL& gurl); 47 void MaybeShowDisclosureForOmnibox(const GURL& gurl);
48 void ShowDisclosureIfRulesPermit(const GURL& gurl);
46 49
47 bool ShouldShowDisclosureForUrl(const GURL& gurl); 50 bool ShouldShowDisclosureForUrl(const GURL& gurl);
48 51
49 // Record metrics, once per client, of the permission state before and after 52 // Record metrics, once per client, of the permission state before and after
50 // the disclosure has been shown. 53 // the disclosure has been shown.
51 void RecordPreDisclosureMetrics(const GURL& gurl); 54 void RecordPreDisclosureMetrics(const GURL& gurl);
52 void RecordPostDisclosureMetrics(const GURL& gurl); 55 void RecordPostDisclosureMetrics(const GURL& gurl);
53 Profile* GetProfile(); 56 Profile* GetProfile();
54 57
55 bool consistent_geolocation_enabled_; 58 bool consistent_geolocation_enabled_;
56 59
57 DISALLOW_COPY_AND_ASSIGN(SearchGeolocationDisclosureTabHelper); 60 DISALLOW_COPY_AND_ASSIGN(SearchGeolocationDisclosureTabHelper);
58 }; 61 };
59 62
60 #endif // CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_SEARCH_GEOLOCATION_DISCLOSU RE_TAB_HELPER_H_ 63 #endif // CHROME_BROWSER_ANDROID_SEARCH_GEOLOCATION_SEARCH_GEOLOCATION_DISCLOSU RE_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698