Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2627793005:
The unittest in ChromeOS touchpad latching cl fixed. (Closed)
DescriptionThe unittest in ChromeOS touchpad latching cl fixed.
This is a follow up for https://codereview.chromium.org/2625453002/
Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0);
at the end of the test. The change is for making sure that last Animate()
won't call ScrollBy when the fling is over.
BUG=526463
TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled
Review-Url: https://codereview.chromium.org/2627793005
Cr-Commit-Position: refs/heads/master@{#443388}
Committed: https://chromium.googlesource.com/chromium/src/+/9c0bde8a43cd39944fd13287e0192f8994619ee3
Patch Set 1 #
Messages
Total messages: 17 (12 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ========== to ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. TBR=bokan@chromium.org, tdresser@chromium.org BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ==========
Description was changed from ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. TBR=bokan@chromium.org, tdresser@chromium.org BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ========== to ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. TBR=bokan@chromium.org,tdresser@chromium.org BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ==========
Description was changed from ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. TBR=bokan@chromium.org,tdresser@chromium.org BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ========== to ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ==========
The CQ bit was checked by sahel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sahel@chromium.org changed reviewers: + bokan@chromium.org, tdresser@chromium.org
lgtm
LGTM
The CQ bit was checked by sahel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484259914680160,
"parent_rev": "eb97055cd797c4fce7e56afdb010ea8c8657f772", "commit_rev":
"9c0bde8a43cd39944fd13287e0192f8994619ee3"}
Message was sent while issue was closed.
Description was changed from ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled ========== to ========== The unittest in ChromeOS touchpad latching cl fixed. This is a follow up for https://codereview.chromium.org/2625453002/ Animate() called after EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); at the end of the test. The change is for making sure that last Animate() won't call ScrollBy when the fling is over. BUG=526463 TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled Review-Url: https://codereview.chromium.org/2627793005 Cr-Commit-Position: refs/heads/master@{#443388} Committed: https://chromium.googlesource.com/chromium/src/+/9c0bde8a43cd39944fd13287e019... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9c0bde8a43cd39944fd13287e019... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
