Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2627783006: Version 5.7.442.2 (cherry-pick) (Closed)

Created:
3 years, 11 months ago by Michael Hablich
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com, v8-merges_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Target Ref:
refs/pending/heads/5.7.442
Project:
v8
Visibility:
Public.

Description

Version 5.7.442.2 (cherry-pick) Merged b4654bf30e63499dd689472bcfde7fbf8c7484c7 Revert of Internalize strings in-place (patchset #20 id:380001 of https://codereview.chromium.org/2549773002/ ) TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2627783006 . Cr-Commit-Position: refs/heads/5.7.442@{#3} Cr-Branched-From: 9856ca24db0bb7092cfe2210f5fd7c57a3d8240f-refs/heads/master@{#42255} Committed: https://chromium.googlesource.com/v8/v8/+/679672b1da584ded235654a2dda324e322e1d85b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -948 lines) Patch
M include/v8.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 4 chunks +4 lines, -12 lines 0 comments Download
M src/arm/codegen-arm.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 6 chunks +9 lines, -17 lines 0 comments Download
M src/arm64/codegen-arm64.cc View 3 chunks +7 lines, -15 lines 0 comments Download
M src/ast/ast-types.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +15 lines, -18 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 18 chunks +65 lines, -100 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-builder.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/types.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/elements.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M src/factory.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/factory.cc View 5 chunks +13 lines, -46 lines 0 comments Download
M src/heap/heap.h View 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +13 lines, -42 lines 0 comments Download
M src/heap/heap-inl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/heap/scavenger.cc View 4 chunks +0 lines, -27 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/ic/accessor-assembler.cc View 4 chunks +2 lines, -6 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ic/keyed-store-generic.cc View 4 chunks +3 lines, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M src/mips/codegen-mips.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 4 chunks +4 lines, -11 lines 0 comments Download
M src/mips64/codegen-mips64.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M src/objects.h View 9 chunks +18 lines, -54 lines 0 comments Download
M src/objects.cc View 14 chunks +21 lines, -102 lines 0 comments Download
M src/objects-body-descriptors-inl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M src/objects-inl.h View 8 chunks +4 lines, -33 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 3 chunks +10 lines, -16 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M src/runtime/runtime-i18n.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-internal.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/s390/codegen-s390.cc View 3 chunks +11 lines, -17 lines 0 comments Download
M src/value-serializer.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/x64/codegen-x64.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/x87/codegen-x87.cc View 3 chunks +9 lines, -16 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 3 chunks +57 lines, -37 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D test/mjsunit/thin-strings.js View 1 chunk +0 lines, -90 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Hablich
3 years, 11 months ago (2017-01-12 15:02:00 UTC) #1
Michael Hablich
Committed patchset #1 (id:1) manually as 679672b1da584ded235654a2dda324e322e1d85b.
3 years, 11 months ago (2017-01-12 15:02:32 UTC) #3
Michael Achenbach
3 years, 11 months ago (2017-01-12 20:02:55 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698