Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2627783002: DevTools: Remove caseSensitive from FilteredListWidget.Delegate (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove caseSensitive from FilteredListWidget.Delegate Makes case sensitivity and option on highlightRanges, which becomes a static method on FilteredListWidget. BUG=none Review-Url: https://codereview.chromium.org/2627783002 Cr-Commit-Position: refs/heads/master@{#443042} Committed: https://chromium.googlesource.com/chromium/src/+/9445305e2f3022015e983398fe3aa56feea9a418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -58 lines) Patch
M third_party/WebKit/Source/devtools/front_end/quick_open/CommandMenu.js View 2 chunks +1 line, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/quick_open/FilteredListWidget.js View 2 chunks +41 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptOutlineDialog.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/StyleSheetOutlineDialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
einbinder
ptal
3 years, 11 months ago (2017-01-11 02:48:59 UTC) #2
dgozman
lgtm
3 years, 11 months ago (2017-01-11 18:30:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627783002/1
3 years, 11 months ago (2017-01-11 19:56:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/98443) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-11 20:13:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627783002/1
3 years, 11 months ago (2017-01-11 22:04:08 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 23:09:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9445305e2f3022015e983398fe3a...

Powered by Google App Engine
This is Rietveld 408576698