Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2627773002: LayoutTheme: Invalidate cache on WebThemeEngine change. (Closed)

Created:
3 years, 11 months ago by tkent
Modified:
3 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTheme: Invalidate cache on WebThemeEngine change. A LayoutThemeDefault instance can be associated to a real WebThemeEngine or a mock WebThemeEngine, which have different metrics. We need to invalidate a cached value when a WebThemeEngine is switched. The bug affects only layout tests. BUG=673754 Review-Url: https://codereview.chromium.org/2627773002 Cr-Commit-Position: refs/heads/master@{#442799} Committed: https://chromium.googlesource.com/chromium/src/+/b554c05ac115a02e49b478fb737604719b479efb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
keishi@, would you review this please?
3 years, 11 months ago (2017-01-11 02:17:59 UTC) #4
keishi
LGTM
3 years, 11 months ago (2017-01-11 02:19:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627773002/1
3 years, 11 months ago (2017-01-11 04:21:46 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 04:26:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b554c05ac115a02e49b478fb7376...

Powered by Google App Engine
This is Rietveld 408576698