Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2627763002: [wasm] JS APIs & memory (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] JS APIs & memory - updated WebAssembly.Instance ctor uses in our tests to match spec - disallowing mem section *and* mem import, as per spec BUG=v8:5824 Review-Url: https://codereview.chromium.org/2627763002 Cr-Commit-Position: refs/heads/master@{#42278} Committed: https://chromium.googlesource.com/v8/v8/+/53137df89a859fca258f9c448dec5a4eba4e47c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -27 lines) Patch
M src/wasm/module-decoder.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-serialization.js View 2 chunks +6 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/import-memory.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 6 chunks +17 lines, -11 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 2 chunks +8 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/module-memory.js View 4 chunks +5 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Mircea Trofin
3 years, 11 months ago (2017-01-11 16:56:05 UTC) #8
titzer
On 2017/01/11 16:56:05, Mircea Trofin wrote: +rossberg should also take a look at this.
3 years, 11 months ago (2017-01-11 17:15:16 UTC) #10
rossberg
Seems to overlap with https://codereview.chromium.org/2620263003/ (which I haven't succeeded landing yet).
3 years, 11 months ago (2017-01-11 17:41:17 UTC) #11
rossberg
On 2017/01/11 17:41:17, rossberg wrote: > Seems to overlap with https://codereview.chromium.org/2620263003/ (which I > haven't ...
3 years, 11 months ago (2017-01-11 17:43:10 UTC) #12
rossberg
LGTM
3 years, 11 months ago (2017-01-12 13:13:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627763002/1
3 years, 11 months ago (2017-01-12 16:03:47 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 16:48:17 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/53137df89a859fca258f9c448dec5a4eba4...

Powered by Google App Engine
This is Rietveld 408576698