exo: Fix use of invalid texture mailbox.

exo: Fix use of invalid texture mailbox.

Texture must be bound before it has a valid mailbox.
https://crrev.com/d40f03 accidentally broke this by
accessing the mailbox before calling BindTexImage.

BUG=679200
Review-Url: https://codereview.chromium.org/2627753003
Cr-Commit-Position: refs/heads/master@{#443005}
Committed: https://chromium.googlesource.com/chromium/src/+/7ee8b4ecbb130b6b88443a0a2cc78c6df5dd7a29

[reveman, 2017-01-11 14:45:43]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org, staraz@chromium.org

[Alex Z., 2017-01-11 14:54:49]

https://codereview.chromium.org/2627753003/diff/1/components/exo/buffer.cc
File components/exo/buffer.cc (right):

https://codereview.chromium.org/2627753003/diff/1/components/exo/buffer.cc#ne...
components/exo/buffer.cc:497: contents_texture->CopyTexImage(
Another sync token is created here. 
Does the texture also need to be bound before having the mailbox?

[reveman, 2017-01-11 18:06:54]

https://codereview.chromium.org/2627753003/diff/1/components/exo/buffer.cc
File components/exo/buffer.cc (right):

https://codereview.chromium.org/2627753003/diff/1/components/exo/buffer.cc#ne...
components/exo/buffer.cc:497: contents_texture->CopyTexImage(
On 2017/01/11 at 14:54:49, StarAZ1 wrote:
> Another sync token is created here. 
> Does the texture also need to be bound before having the mailbox?

The mailbox for |texture| has already been created here as it's only GMB backed
textures that need to be bound before they have a mailbox. The mailbox for
|texture| is generated when creating the instance.

[reveman, 2017-01-11 18:06:57]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 18:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alex Z., 2017-01-11 19:04:03]

lgtm

[reveman, 2017-01-11 19:07:51]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2017-01-11 19:08:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 22:10:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484161671743670,
"parent_rev": "2afc205491aaace614ef521ce636fc59d0a83e8b", "commit_rev":
"7ee8b4ecbb130b6b88443a0a2cc78c6df5dd7a29"}

[commit-bot: I haz the power, 2017-01-11 22:11:28]

Description was changed from

==========
exo: Fix use of invalid texture mailbox.

Texture must be bound before it has a valid mailbox.
https://crrev.com/d40f03 accidentally broke this by
accessing the mailbox before calling BindTexImage.

BUG=679200
==========

to

==========
exo: Fix use of invalid texture mailbox.

Texture must be bound before it has a valid mailbox.
https://crrev.com/d40f03 accidentally broke this by
accessing the mailbox before calling BindTexImage.

BUG=679200

Review-Url: https://codereview.chromium.org/2627753003
Cr-Commit-Position: refs/heads/master@{#443005}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ee8b4ecbb130b6b88443a0a2cc7...
==========

[commit-bot: I haz the power, 2017-01-11 22:11:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ee8b4ecbb130b6b88443a0a2cc7...