Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2627753002: Resets title text color for CollectionViewAccountItem (Closed)

Created:
3 years, 11 months ago by sczs
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resets title text color for CollectionViewAccountItem The title text color was being changed on the VC, so we need to reset it as well. BUG=674493 Review-Url: https://codereview.chromium.org/2627753002 Cr-Commit-Position: refs/heads/master@{#442882} Committed: https://chromium.googlesource.com/chromium/src/+/3861e32ac068bf7e92aece084bbf77ddae9c298c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/chrome/browser/ui/collection_view/cells/collection_view_account_item.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
sczs
Hi Louis, PTAL at a small CL to completely fix the bug.
3 years, 11 months ago (2017-01-11 00:29:15 UTC) #3
lpromero
lgtm
3 years, 11 months ago (2017-01-11 12:19:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627753002/1
3 years, 11 months ago (2017-01-11 12:19:46 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 12:29:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3861e32ac068bf7e92aece084bbf...

Powered by Google App Engine
This is Rietveld 408576698