Don't enable accessibility just because IAccessible2 APIs are queried.

Don't enable accessibility just because IAccessible2 APIs are queried.

Chrome now has support for more fine-grained accessibility modes.
Individual accessibility APIs now enable parts of accessibility support
as needed, but log data is suggesting that lots of clients are calling
QueryService with IAccessible2 as the IID argument even though they
don't need full accessibility support, so let's delete this particular
trigger.

BUG=672205, 644647
Review-Url: https://codereview.chromium.org/2627733003
Cr-Commit-Position: refs/heads/master@{#442757}
Committed: https://chromium.googlesource.com/chromium/src/+/451daad4f60a3ca0f7508097309d11a15da480fe

[dmazzoni, 2017-01-11 00:20:57]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[aboxhall, 2017-01-11 00:22:07]

lgtm

Is there any chance this could cause accessibility not to be enabled when it
should be?

[dmazzoni, 2017-01-11 00:25:32]

On 2017/01/11 00:22:07, aboxhall wrote:
> lgtm
> 
> Is there any chance this could cause accessibility not to be enabled when it
> should be?

In the previous change I added calls to set the accessibility mode at
the top of dozens of different accessibility API calls, so those should
be sufficient.

But I'm going to keep an eye on UMA over the next few days and reach out
to some users to make sure nobody's experiencing any regressions.

One thing that's nice is that most of the larger refactoring already
happened, so if this ends up causing problems it's a nice tiny change
to revert.

[dmazzoni, 2017-01-11 00:25:38]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-01-11 00:26:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 01:26:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484094338582960, "parent_rev":
"e2867aed46b3f00f3735d310144d6ef638f8be1a", "commit_rev":
"451daad4f60a3ca0f7508097309d11a15da480fe"}

[commit-bot: I haz the power, 2017-01-11 01:26:53]

Description was changed from

==========
Don't enable accessibility just because IAccessible2 APIs are queried.

Chrome now has support for more fine-grained accessibility modes.
Individual accessibility APIs now enable parts of accessibility support
as needed, but log data is suggesting that lots of clients are calling
QueryService with IAccessible2 as the IID argument even though they
don't need full accessibility support, so let's delete this particular
trigger.

BUG=672205,644647
==========

to

==========
Don't enable accessibility just because IAccessible2 APIs are queried.

Chrome now has support for more fine-grained accessibility modes.
Individual accessibility APIs now enable parts of accessibility support
as needed, but log data is suggesting that lots of clients are calling
QueryService with IAccessible2 as the IID argument even though they
don't need full accessibility support, so let's delete this particular
trigger.

BUG=672205,644647

Review-Url: https://codereview.chromium.org/2627733003
Cr-Commit-Position: refs/heads/master@{#442757}
Committed:
https://chromium.googlesource.com/chromium/src/+/451daad4f60a3ca0f7508097309d...
==========

[commit-bot: I haz the power, 2017-01-11 01:26:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/451daad4f60a3ca0f7508097309d...