Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2627723006: Update parser so tests pass. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, karlklose, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1646 lines, -91 lines) Patch
M pkg/dart_parser/bin/parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/dart_parser/lib/dart_parser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/dart_parser/lib/parser.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M pkg/dart_parser/lib/src/class_member_parser.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dart_parser/lib/src/error_kind.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_parser/lib/src/listener.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dart_parser/lib/src/main.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/dart_parser/lib/src/parser.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/dart_parser/lib/src/top_level_parser.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dart_parser/test/parser.status View 1 chunk +1612 lines, -0 lines 0 comments Download
M pkg/dart_parser/test/parser_suite.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/dart_parser/testing.json View 2 chunks +4 lines, -1 line 0 comments Download
A + pkg/dart_scanner/lib/dart_scanner.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/dart_scanner/lib/scanner.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M pkg/dart_scanner/lib/src/abstract_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/main.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/testing/scanner_chain.dart View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2627093007 Patch 20001

Messages

Total messages: 7 (4 generated)
ahe
3 years, 11 months ago (2017-01-13 06:51:41 UTC) #4
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-13 08:37:52 UTC) #5
ahe
3 years, 11 months ago (2017-01-13 10:23:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:40001) manually as
8ab0f38125318f63b28d55fd7a33a547eda5a81c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698