Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2627093007: Update scanner so tests pass. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, karlklose, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fe_integration
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on CL 2629543008. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -15 lines) Patch
M .packages View 1 2 chunks +3 lines, -1 line 0 comments Download
M pkg/dart_scanner/bin/scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/dart_scanner/lib/io.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dart_scanner/lib/scanner.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dart_scanner/lib/src/abstract_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/array_based_scanner.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/dart_scanner/lib/src/characters.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/keyword.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/main.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dart_scanner/lib/src/precedence.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/token.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/token_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/src/utf8_bytes_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/lib/testing/scanner_chain.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/dart_scanner/test/scanner.status View 2 chunks +123 lines, -0 lines 0 comments Download
M pkg/dart_scanner/test/scanner_suite.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart_scanner/testing.json View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2629543008 Patch 1

Dependent Patchsets:

Issue 2627723006 Patch 40001

Messages

Total messages: 7 (3 generated)
ahe
Note: also depends on pkg/link which I haven't copied yet.
3 years, 11 months ago (2017-01-12 12:36:32 UTC) #2
ahe
Johnni, Karl is out today, could you take a look?
3 years, 11 months ago (2017-01-13 06:48:55 UTC) #4
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-13 08:32:51 UTC) #5
ahe
3 years, 11 months ago (2017-01-13 10:18:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a5b0cd031d0c8d2254fe2fd2f50089c63b4a08e8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698