ServiceWorker: adding a crash key to check if a new process is launched

ServiceWorker: adding a crash key to check if a new process is launched

This patch is to check if the mismatching EmbeddedWorker was launched on a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633
Review-Url: https://codereview.chromium.org/2627723004
Cr-Commit-Position: refs/heads/master@{#443543}
Committed: https://chromium.googlesource.com/chromium/src/+/994437489ea2c9aaf7fac316a90bf4dffeedf7b2

[shimazu, 2017-01-12 04:59:42]

Description was changed from

==========
ServiceWorker: adding a crash key to check if a new process is launched

This patch is to check if the mismatching EmbeddedWorker is launched with a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633
==========

to

==========
ServiceWorker: adding a crash key to check if a new process is launched

This patch is to check if the mismatching EmbeddedWorker was launched on a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633
==========

[shimazu, 2017-01-12 05:41:44]

shimazu@chromium.org changed reviewers:
+ horo@chromium.org

[shimazu, 2017-01-12 05:41:45]

ptal

[horo, 2017-01-12 09:20:21]

lgtm

[shimazu, 2017-01-12 10:16:03]

shimazu@chromium.org changed reviewers:
+ jam@chromium.org

[shimazu, 2017-01-12 10:16:04]

jam@chromium.org: Please review changes in *crash_keys.cc,
chrome_crash_reporter_client_win.cc

[jam, 2017-01-12 17:56:07]

lgtm

[shimazu, 2017-01-13 00:10:55]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:12:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 01:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 01:03:00]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[shimazu, 2017-01-13 08:08:31]

The CQ bit was checked by shimazu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 08:08:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shimazu, 2017-01-13 08:09:59]

Fixed the crash.

horo@-san:
Could you take a look just in case?

[horo, 2017-01-13 08:51:37]

lgtm

[shimazu, 2017-01-13 08:52:59]

The CQ bit was unchecked by shimazu@chromium.org

[shimazu, 2017-01-13 08:53:06]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2017-01-13 08:53:06]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2627723004/#ps40001
(title: "Don't record is_new_process when process hasn't been allocated")

[commit-bot: I haz the power, 2017-01-13 08:53:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 11:37:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 11:37:08]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[shimazu, 2017-01-13 12:06:06]

The CQ bit was checked by shimazu@chromium.org

[commit-bot: I haz the power, 2017-01-13 12:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 13:17:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484309166852390,
"parent_rev": "6422f3b2391675817cc28ed311776067853f5757", "commit_rev":
"994437489ea2c9aaf7fac316a90bf4dffeedf7b2"}

[commit-bot: I haz the power, 2017-01-13 13:18:16]

Description was changed from

==========
ServiceWorker: adding a crash key to check if a new process is launched

This patch is to check if the mismatching EmbeddedWorker was launched on a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633
==========

to

==========
ServiceWorker: adding a crash key to check if a new process is launched

This patch is to check if the mismatching EmbeddedWorker was launched on a new
process. If it's true, OnSetHostedVersionId IPC might be reached after
restarting the EmbeddedWorker.

BUG=668633

Review-Url: https://codereview.chromium.org/2627723004
Cr-Commit-Position: refs/heads/master@{#443543}
Committed:
https://chromium.googlesource.com/chromium/src/+/994437489ea2c9aaf7fac316a90b...
==========

[commit-bot: I haz the power, 2017-01-13 13:18:17]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/994437489ea2c9aaf7fac316a90b...