Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2627663002: Remove Finch config control for contextual search. (Closed)

Created:
3 years, 11 months ago by marq (ping after 24h)
Modified:
3 years, 11 months ago
Reviewers:
lindsayw
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Finch config control for contextual search. BUG=679349 Review-Url: https://codereview.chromium.org/2627663002 Cr-Commit-Position: refs/heads/master@{#442847} Committed: https://chromium.googlesource.com/chromium/src/+/8037d06ae05fcf927fa9feb0cb61d3f05c481267

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm View 3 chunks +15 lines, -16 lines 1 comment Download
M ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator_unittest.mm View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
marq (ping after 24h)
3 years, 11 months ago (2017-01-10 18:40:47 UTC) #2
lindsayw
lgtm https://codereview.chromium.org/2627663002/diff/1/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm File ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm (right): https://codereview.chromium.org/2627663002/diff/1/ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm#newcode74 ios/chrome/browser/ui/contextual_search/touch_to_search_permissions_mediator.mm:74: // If both enable and disable flags are ...
3 years, 11 months ago (2017-01-10 19:08:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627663002/1
3 years, 11 months ago (2017-01-11 07:28:08 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:20:26 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8037d06ae05fcf927fa9feb0cb61...

Powered by Google App Engine
This is Rietveld 408576698