Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1558)

Issue 2627633002: [ObjC ARC] Converts ios/chrome/browser/device_sharing:eg_tests to ARC. (Closed)

Created:
3 years, 11 months ago by stkhapugin
Modified:
3 years, 11 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/device_sharing:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2627633002 Cr-Commit-Position: refs/heads/master@{#442859} Committed: https://chromium.googlesource.com/chromium/src/+/ae00364f8accb45d8ee99270c9bfff763731c3f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/device_sharing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/device_sharing/handoff_manager_egtest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
stkhapugin
PTAL
3 years, 11 months ago (2017-01-10 16:06:48 UTC) #6
noyau (Ping after 24h)
lgtm
3 years, 11 months ago (2017-01-10 17:25:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627633002/1
3 years, 11 months ago (2017-01-11 10:27:13 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:34:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae00364f8accb45d8ee99270c9bf...

Powered by Google App Engine
This is Rietveld 408576698