Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2627543004: [test] Fix test-api.cc test for caching of FunctionTemplate. (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix test-api.cc test for caching of FunctionTemplate. R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2627543004 Cr-Commit-Position: refs/heads/master@{#42188} Committed: https://chromium.googlesource.com/v8/v8/+/6921b71d417fcf3b6cfacbacd8943527b02efc4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +6 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
titzer
3 years, 11 months ago (2017-01-10 14:30:50 UTC) #1
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-10 16:57:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627543004/1
3 years, 11 months ago (2017-01-10 16:57:45 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 17:00:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6921b71d417fcf3b6cfacbacd8943527b02...

Powered by Google App Engine
This is Rietveld 408576698