[wasm] Prerequisites for WebAssembly Table.Grow

[wasm] Prerequisites for WebAssembly Table.Grow
 - Refactor Dispatch tables to have separate function, signature tables
 - New Relocation type for WasmFunctionTableReference, assembler, compiler support.
 - RelocInfo helper functions for Wasm references

Review-Url: https://codereview.chromium.org/2627543003
Cr-Commit-Position: refs/heads/master@{#42192}
Committed: https://chromium.googlesource.com/v8/v8/+/0c4b8ff44ce4ef0cae06c964679c98c32f8bd40f

[gdeepti, 2017-01-10 05:12:54]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 05:13:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 05:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 05:41:30]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-01-10 06:25:50]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:25:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:31:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:31:58]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[gdeepti, 2017-01-10 06:35:17]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 06:35:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 06:42:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 06:42:01]

Dry run: Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[gdeepti, 2017-01-10 07:30:14]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 07:30:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-01-10 07:37:27]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 07:37:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-01-10 07:59:50]

Description was changed from

==========
[wasm] Prerequisites for WebAssembly Table.Grow
 - Refactor Dispatch tables to have separate function, signature tables
 - New Relocation type for WasmFunctionTableReference, assembler, compiler
support.
==========

to

==========
[wasm] Prerequisites for WebAssembly Table.Grow
 - Refactor Dispatch tables to have separate function, signature tables
 - New Relocation type for WasmFunctionTableReference, assembler, compiler
support.
 - RelocInfo helper functions for Wasm references
==========

[gdeepti, 2017-01-10 07:59:51]

gdeepti@chromium.org changed reviewers:
+ bradnelson@chromium.org, mtrofin@chromium.org, titzer@chromium.org

[commit-bot: I haz the power, 2017-01-10 08:02:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 08:02:13]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2017-01-10 08:33:09]

lgtm

https://codereview.chromium.org/2627543003/diff/80001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2627543003/diff/80001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:2974: auto signature_handle =
module_->instance->signature_tables[i];
(Optional), might be clearer to do each separately rather than interleaved (but
might not)

[titzer, 2017-01-10 09:42:45]

lgtm

https://codereview.chromium.org/2627543003/diff/80001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/2627543003/diff/80001/src/assembler.cc#newcod...
src/assembler.cc:368: unchecked_update_wasm_memory_size(updated_size_reference,
icache_flush_mode);
This is reusing unchecked_update_wasm_memory_size(), which I think should be OK
(both are 32-bit constants), but maybe it's best to have a more general name for
that function now.

[gdeepti, 2017-01-10 18:35:51]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 18:35:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-01-10 18:49:25]

https://codereview.chromium.org/2627543003/diff/80001/src/assembler.cc
File src/assembler.cc (right):

https://codereview.chromium.org/2627543003/diff/80001/src/assembler.cc#newcod...
src/assembler.cc:368: unchecked_update_wasm_memory_size(updated_size_reference,
icache_flush_mode);
On 2017/01/10 09:42:45, titzer wrote:
> This is reusing unchecked_update_wasm_memory_size(), which I think should be
OK
> (both are 32-bit constants), but maybe it's best to have a more general name
for
> that function now.

Reused function for the same reason, fixed now to be unchecked_update_wasm_size
as a general size update method instead of unchecked_update_wasm_memory_size.

https://codereview.chromium.org/2627543003/diff/80001/src/compiler/wasm-compi...
File src/compiler/wasm-compiler.cc (right):

https://codereview.chromium.org/2627543003/diff/80001/src/compiler/wasm-compi...
src/compiler/wasm-compiler.cc:2974: auto signature_handle =
module_->instance->signature_tables[i];
On 2017/01/10 08:33:09, bradnelson wrote:
> (Optional), might be clearer to do each separately rather than interleaved
(but
> might not)

Leaving as is for now because separating them out further will need an
additional DCHECK.

[commit-bot: I haz the power, 2017-01-10 19:05:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 19:05:07]

Dry run: This issue passed the CQ dry run.

[gdeepti, 2017-01-10 19:05:28]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2017-01-10 19:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
bradnelson@chromium.org
Link to the patchset: https://codereview.chromium.org/2627543003/#ps100001
(title: "Rename update function")

[commit-bot: I haz the power, 2017-01-10 19:05:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 19:07:36]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1484075128167170,
"parent_rev": "b1cfa6448cd6e048b5dd55ba9726805c9221ffe1", "commit_rev":
"0c4b8ff44ce4ef0cae06c964679c98c32f8bd40f"}

[commit-bot: I haz the power, 2017-01-10 19:07:42]

Description was changed from

==========
[wasm] Prerequisites for WebAssembly Table.Grow
 - Refactor Dispatch tables to have separate function, signature tables
 - New Relocation type for WasmFunctionTableReference, assembler, compiler
support.
 - RelocInfo helper functions for Wasm references
==========

to

==========
[wasm] Prerequisites for WebAssembly Table.Grow
 - Refactor Dispatch tables to have separate function, signature tables
 - New Relocation type for WasmFunctionTableReference, assembler, compiler
support.
 - RelocInfo helper functions for Wasm references

Review-Url: https://codereview.chromium.org/2627543003
Cr-Commit-Position: refs/heads/master@{#42192}
Committed:
https://chromium.googlesource.com/v8/v8/+/0c4b8ff44ce4ef0cae06c964679c98c32f8...
==========

[commit-bot: I haz the power, 2017-01-10 19:07:43]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/0c4b8ff44ce4ef0cae06c964679c98c32f8...