ash/common/shelf/shelf_window_watcher_item_delegate.h - Issue 2627533002: Replace ShelfItemDelegate::GetTitle() with ShelfItem::title.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_window_watcher_item_delegate.h

Issue 2627533002: Replace ShelfItemDelegate::GetTitle() with ShelfItem::title. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/shelf_window_watcher_item_delegate.h

diff --git a/ash/common/shelf/shelf_window_watcher_item_delegate.h b/ash/common/shelf/shelf_window_watcher_item_delegate.h

index 3dab83b31d1362708d4ae26d4fe8889e3f86db74..0591a7dd954887d2641c98227369f49582818c04 100644

--- a/ash/common/shelf/shelf_window_watcher_item_delegate.h

+++ b/ash/common/shelf/shelf_window_watcher_item_delegate.h

@@ -23,7 +23,6 @@ class ShelfWindowWatcherItemDelegate : public ShelfItemDelegate {

// ShelfItemDelegate overrides:

ShelfItemDelegate::PerformedAction ItemSelected(

const ui::Event& event) override;

- base::string16 GetTitle() override;

ShelfMenuModel* CreateApplicationMenu(int event_flags) override;

void Close() override;