ash/common/shelf/shelf_window_watcher_item_delegate.cc - Issue 2627533002: Replace ShelfItemDelegate::GetTitle() with ShelfItem::title.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_window_watcher_item_delegate.cc

Issue 2627533002: Replace ShelfItemDelegate::GetTitle() with ShelfItem::title. (Closed)

Patch Set: Address comments. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/shelf_window_watcher_item_delegate.cc

diff --git a/ash/common/shelf/shelf_window_watcher_item_delegate.cc b/ash/common/shelf/shelf_window_watcher_item_delegate.cc

index 0738ce567c8cad95f41962068edacc6638cf1faf..303ef6a0841733085aead5007dbedf9d3ef66069 100644

--- a/ash/common/shelf/shelf_window_watcher_item_delegate.cc

+++ b/ash/common/shelf/shelf_window_watcher_item_delegate.cc

@@ -55,10 +55,6 @@ ShelfItemDelegate::PerformedAction ShelfWindowWatcherItemDelegate::ItemSelected(

return kExistingWindowActivated;

}

-base::string16 ShelfWindowWatcherItemDelegate::GetTitle() {

- return window_->GetTitle();

ShelfMenuModel* ShelfWindowWatcherItemDelegate::CreateApplicationMenu(

int event_flags) {

return nullptr;