Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2627523003: Observe network changes from network thread in DomainReliabilityMonitor. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 11 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Observe network changes from network thread in DomainReliabilityMonitor. From observer_list_threadsafe.h: // If the observer to be removed is in the list, RemoveObserver MUST // be called from the same thread which called AddObserver. This rule is currently not respected by DomainReliabilityMonitor, which prevents the addition of a DCHECK. With this CL, the rule is respected and |last_network_change_time_| is read/written from the same thread (no data race). BUG= Review-Url: https://codereview.chromium.org/2627523003 Cr-Commit-Position: refs/heads/master@{#443283} Committed: https://chromium.googlesource.com/chromium/src/+/b0002b84acf5c71a6c257a068fb56d588e5e9d47

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M components/domain_reliability/monitor.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
fdoray
PTAL
3 years, 11 months ago (2017-01-10 15:24:04 UTC) #8
Julia Tuttle
lgtm, thanks.
3 years, 11 months ago (2017-01-12 16:46:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627523003/1
3 years, 11 months ago (2017-01-12 16:47:50 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 17:53:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b0002b84acf5c71a6c257a068fb5...

Powered by Google App Engine
This is Rietveld 408576698