Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2627483002: [HBD] Intercept Flash navigations in popup windows. (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, jam
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[HBD] Intercept Flash navigations in popup windows. This CL turns up the Flash download interception aggression - by making it apply to popup windows as well. This should be fairly harmless. BUG=676096 Review-Url: https://codereview.chromium.org/2590363003 Cr-Commit-Position: refs/heads/master@{#440518} (cherry picked from commit d60fef6f171bacc82ecaf3f1d4b70450d49ad1cc) Review-Url: https://codereview.chromium.org/2627483002 . Cr-Commit-Position: refs/branch-heads/2924@{#708} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/d3ed2163bfdd00c29966c43c46afbd678ab4a8a9

Patch Set 1 #

Patch Set 2 : Remove tests from the merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/plugins/flash_download_interception.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627483002/20001
3 years, 11 months ago (2017-01-10 00:27:24 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-10 00:27:25 UTC) #4
tommycli
3 years, 11 months ago (2017-01-10 00:28:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d3ed2163bfdd00c29966c43c46afbd678ab4a8a9.

Powered by Google App Engine
This is Rietveld 408576698