Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4728)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Fix chromeos browser tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
index b2cc64350437c232ff54f80ee3d4963e7a6b1ca0..1761d1a840fbdcf10729fe6901f84b59764b0c86 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
@@ -114,7 +114,7 @@ class MediaRouterUITest : public ChromeRenderViewHostTestHarness {
MediaSink CreateSinkCompatibleWithAllSources() {
MediaSink sink("sinkId", "sinkName", MediaSink::GENERIC);
for (auto* observer : media_sinks_observers_)
- observer->OnSinksUpdated({sink}, std::vector<GURL>());
+ observer->OnSinksUpdated({sink}, std::vector<url::Origin>());
return sink;
}
@@ -506,7 +506,7 @@ TEST_F(MediaRouterUITest, NotFoundErrorOnCloseWithNoCompatibleSinks) {
// presentation url to cause a NotFoundError.
std::vector<MediaSink> sinks;
sinks.emplace_back("sink id", "sink name", MediaSink::GENERIC);
- std::vector<GURL> origins;
+ std::vector<url::Origin> origins;
for (auto* observer : media_sinks_observers_) {
if (observer->source().id() != presentation_url.spec()) {
observer->OnSinksUpdated(sinks, origins);
@@ -536,7 +536,7 @@ TEST_F(MediaRouterUITest, AbortErrorOnClose) {
// a NotFoundError.
std::vector<MediaSink> sinks;
sinks.emplace_back("sink id", "sink name", MediaSink::GENERIC);
- std::vector<GURL> origins;
+ std::vector<url::Origin> origins;
MediaSource::Id presentation_source_id =
MediaSourceForPresentationUrl(presentation_url).id();
for (auto* observer : media_sinks_observers_) {

Powered by Google App Engine
This is Rietveld 408576698