Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8712)

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: Fix chromeos browser tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/media_router/media_router_ui.cc
diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc
index badd597883f88b65c4bcb6a99aeb7e8f3fa57be9..f6a65130b37a337d390f7c9a21569d01ffa4f413 100644
--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc
+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc
@@ -276,7 +276,7 @@ void MediaRouterUI::InitCommon(content::WebContents* initiator) {
query_result_manager_->AddObserver(this);
// Use a placeholder URL as origin for mirroring.
- GURL origin(chrome::kChromeUIMediaRouterURL);
+ url::Origin origin((GURL(chrome::kChromeUIMediaRouterURL)));
mark a. foltz 2017/01/17 21:30:45 Extra ()
steimel 2017/01/18 01:52:35 The extra () are needed or else I get a compile er
// Desktop mirror mode is always available.
query_result_manager_->SetSourcesForCastMode(
@@ -318,7 +318,7 @@ void MediaRouterUI::OnDefaultPresentationChanged(
presentation_request_.reset(new PresentationRequest(presentation_request));
query_result_manager_->SetSourcesForCastMode(
MediaCastMode::DEFAULT, sources,
- presentation_request_->frame_url().GetOrigin());
+ url::Origin(presentation_request_->frame_url().GetOrigin()));
// Register for MediaRoute updates. NOTE(mfoltz): If there are multiple
// sources that can be connected to via the dialog, this will break. We will
// need to observe multiple sources (keyed by sinks) in that case. As this is
@@ -390,7 +390,7 @@ void MediaRouterUI::UIInitialized() {
bool MediaRouterUI::CreateRoute(const MediaSink::Id& sink_id,
MediaCastMode cast_mode) {
MediaSource::Id source_id;
- GURL origin;
+ url::Origin origin;
std::vector<MediaRouteResponseCallback> route_response_callbacks;
base::TimeDelta timeout;
bool incognito;
@@ -408,7 +408,7 @@ bool MediaRouterUI::SetRouteParameters(
const MediaSink::Id& sink_id,
MediaCastMode cast_mode,
MediaSource::Id* source_id,
- GURL* origin,
+ url::Origin* origin,
std::vector<MediaRouteResponseCallback>* route_response_callbacks,
base::TimeDelta* timeout,
bool* incognito) {
@@ -438,8 +438,9 @@ bool MediaRouterUI::SetRouteParameters(
}
current_route_request_id_ = ++route_request_counter_;
- *origin = for_default_source ? presentation_request_->frame_url().GetOrigin()
- : GURL(chrome::kChromeUIMediaRouterURL);
+ *origin = for_default_source
+ ? url::Origin(presentation_request_->frame_url().GetOrigin())
+ : url::Origin(GURL(chrome::kChromeUIMediaRouterURL));
DVLOG(1) << "DoCreateRoute: origin: " << *origin;
// There are 3 cases. In cases (1) and (3) the MediaRouterUI will need to be
@@ -485,7 +486,7 @@ bool MediaRouterUI::SetRouteParameters(
bool MediaRouterUI::ConnectRoute(const MediaSink::Id& sink_id,
const MediaRoute::Id& route_id) {
MediaSource::Id source_id;
- GURL origin;
+ url::Origin origin;
std::vector<MediaRouteResponseCallback> route_response_callbacks;
base::TimeDelta timeout;
bool incognito;
@@ -651,7 +652,7 @@ void MediaRouterUI::OnSearchSinkResponseReceived(
handler_->ReturnSearchResult(found_sink_id);
MediaSource::Id source_id;
- GURL origin;
+ url::Origin origin;
std::vector<MediaRouteResponseCallback> route_response_callbacks;
base::TimeDelta timeout;
bool incognito;

Powered by Google App Engine
This is Rietveld 408576698