Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1616)

Unified Diff: chrome/browser/media/router/media_sinks_observer_unittest.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)
Patch Set: return an Origin instead of GURL for GetLastCommittedURLForFrame Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/media_sinks_observer_unittest.cc
diff --git a/chrome/browser/media/router/media_sinks_observer_unittest.cc b/chrome/browser/media/router/media_sinks_observer_unittest.cc
index c5a340cdb0637fb4e4fd7de2504663f6f18630ac..839a485b31d6c4c2fc77df8b82107c348586dffc 100644
--- a/chrome/browser/media/router/media_sinks_observer_unittest.cc
+++ b/chrome/browser/media/router/media_sinks_observer_unittest.cc
@@ -14,8 +14,8 @@ TEST(MediaSinksObserverTest, OriginMatching) {
MockMediaRouter router;
MediaSource source(
MediaSourceForPresentationUrl(GURL("https://presentation.com")));
- GURL origin("https://origin.com");
- std::vector<GURL> origin_list;
+ url::Origin origin((GURL("https://origin.com")));
dcheng 2017/01/26 04:16:32 Nit: Here and elsewhere write: url::Origin origin{
steimel 2017/01/27 00:28:59 Done.
+ std::vector<url::Origin> origin_list;
mark a. foltz 2017/01/24 04:04:17 nit: origin_list({origin}) instead of calling push
steimel 2017/01/25 19:01:11 Done.
origin_list.push_back(origin);
std::vector<MediaSink> sink_list;
sink_list.push_back(MediaSink("sinkId", "Sink", MediaSink::IconType::CAST));
@@ -25,9 +25,9 @@ TEST(MediaSinksObserverTest, OriginMatching) {
observer.OnSinksUpdated(sink_list, origin_list);
EXPECT_CALL(observer, OnSinksReceived(SequenceEquals(sink_list)));
- observer.OnSinksUpdated(sink_list, std::vector<GURL>());
+ observer.OnSinksUpdated(sink_list, std::vector<url::Origin>());
- GURL origin2("https://differentOrigin.com");
+ url::Origin origin2((GURL("https://differentOrigin.com")));
origin_list.clear();
origin_list.push_back(origin2);
EXPECT_CALL(observer, OnSinksReceived(testing::IsEmpty()));

Powered by Google App Engine
This is Rietveld 408576698