chrome/browser/media/android/router/media_router_dialog_controller_android.cc - Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/android/router/media_router_dialog_controller_android.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)

Patch Set: return an Origin instead of GURL for GetLastCommittedURLForFrame Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/android/router/media_router_android.cc ('K') | « chrome/browser/media/android/router/media_router_android.cc ('k') | chrome/browser/media/router/BUILD.gn » ('j') | chrome/browser/media/router/media_sinks_observer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/android/router/media_router_dialog_controller_android.cc

diff --git a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc

index 44296df589e61a9ac073421d3bc0b477918c5b5e..1030ce541bc217323cfb989a1fc94300295e62bb 100644

--- a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc

+++ b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc

@@ -53,7 +53,7 @@ void MediaRouterDialogControllerAndroid::OnSinkSelected(

// TODO(crbug.com/627655): Support multiple URLs.

const MediaSource::Id source_id =

presentation_request.GetMediaSources()[0].id();

- const GURL origin = presentation_request.frame_url().GetOrigin();

+ const url::Origin origin = presentation_request.frame_origin();

mark a. foltz 2017/01/24 04:04:17 const auto& origin =

steimel 2017/01/25 19:01:11 Done.

std::vector<MediaRouteResponseCallback> route_response_callbacks;

route_response_callbacks.push_back(