chrome/browser/media/router/media_router_dialog_controller_unittest.cc - Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/media_router_dialog_controller_unittest.cc

Issue 2627463003: Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (Closed)

Patch Set: return an Origin instead of GURL for GetLastCommittedURLForFrame Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/android/router/media_router_dialog_controller_android.cc ('K') | « chrome/browser/media/router/media_router.h ('k') | chrome/browser/media/router/media_sinks_observer.h » ('j') | chrome/browser/media/router/media_sinks_observer_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/media_router_dialog_controller_unittest.cc

diff --git a/chrome/browser/media/router/media_router_dialog_controller_unittest.cc b/chrome/browser/media/router/media_router_dialog_controller_unittest.cc

index 9b36a4ae78d018f3ed48a6b7b5b2071013cad8b8..f66a03b825e4074ee17a896c46a0935b05ffe9c2 100644

--- a/chrome/browser/media/router/media_router_dialog_controller_unittest.cc

+++ b/chrome/browser/media/router/media_router_dialog_controller_unittest.cc

@@ -71,7 +71,7 @@ class MediaRouterDialogControllerTest : public ChromeRenderViewHostTestHarness {

new CreatePresentationConnectionRequest(

RenderFrameHostId(1, 2),

{GURL("http://example.com"), GURL("http://example2.com")},

- GURL("http://google.com"),

+ url::Origin(GURL("http://google.com")),

base::Bind(&MediaRouterDialogControllerTest::RequestSuccess,

base::Unretained(this)),

base::Bind(&MediaRouterDialogControllerTest::RequestError,