Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2627453006: [test] Fix field type tracking tests to use a stable map by construction. (Closed)

Created:
3 years, 11 months ago by titzer
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix field type tracking tests to use a stable map by construction. BUG= R=clemensh@chromium.org,verwaest@chromium.org Review-Url: https://codereview.chromium.org/2627453006 Cr-Commit-Position: refs/heads/master@{#42195} Committed: https://chromium.googlesource.com/v8/v8/+/a24fe91ce9f4f6f992339fe6b7fddb7c78833255

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -11 lines) Patch
M test/cctest/test-field-type-tracking.cc View 3 chunks +27 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
titzer
3 years, 11 months ago (2017-01-10 18:43:59 UTC) #1
titzer
On 2017/01/10 18:43:59, titzer wrote: PTAL. The backstory to this CL is that flipping the ...
3 years, 11 months ago (2017-01-10 18:45:05 UTC) #4
Clemens Hammacher
lgtm
3 years, 11 months ago (2017-01-10 18:50:10 UTC) #8
bradn
lgtm
3 years, 11 months ago (2017-01-10 19:07:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627453006/1
3 years, 11 months ago (2017-01-10 19:13:47 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 19:15:28 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a24fe91ce9f4f6f992339fe6b7fddb7c788...

Powered by Google App Engine
This is Rietveld 408576698