Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2627453004: Tweaks to new BrowserThreadImpl/BrowserMainLoop logic. (Closed)

Created:
3 years, 11 months ago by gab
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, fdoray, robliao
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tweaks to new BrowserThreadImpl/BrowserMainLoop logic. After reviewing https://codereview.chromium.org/2464233002 closely one more time in the light of http://crbug.com/677034, these are the only things I could find (neither of which should affect that issue on all platforms but that's another story...). Review-Url: https://codereview.chromium.org/2627453004 Cr-Commit-Position: refs/heads/master@{#442611} Committed: https://chromium.googlesource.com/chromium/src/+/2cad8b6680852a10a9e6e342c8b78dd701e8c656

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -0 lines 1 comment Download
M content/browser/browser_thread_impl.cc View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 14 (9 generated)
gab
avi PTAL and CQ, thanks! https://codereview.chromium.org/2627453004/diff/1/content/browser/browser_main_loop.cc File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/2627453004/diff/1/content/browser/browser_main_loop.cc#newcode1056 content/browser/browser_main_loop.cc:1056: options.timer_slack = base::TIMER_SLACK_MAXIMUM; Forgot ...
3 years, 11 months ago (2017-01-10 15:48:29 UTC) #3
fdoray
lgtm
3 years, 11 months ago (2017-01-10 15:54:10 UTC) #7
Avi (use Gerrit)
lgtm
3 years, 11 months ago (2017-01-10 16:05:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627453004/1
3 years, 11 months ago (2017-01-10 16:05:56 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 16:40:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2cad8b6680852a10a9e6e342c8b7...

Powered by Google App Engine
This is Rietveld 408576698