Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Issue 2627453003: [ObjC ARC] Converts ios/chrome/app/spotlight:unit_tests to ARC. (Closed)

Created:
3 years, 11 months ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/app/spotlight:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2627453003 Cr-Commit-Position: refs/heads/master@{#442863} Committed: https://chromium.googlesource.com/chromium/src/+/7caec88b05daa5caec5c923ff60d84e96a98f8ff

Patch Set 1 #

Patch Set 2 : remove scoped_nsobject #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M ios/chrome/app/spotlight/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/app/spotlight/spotlight_manager_unittest.mm View 1 7 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
stkhapugin
remove scoped_nsobject
3 years, 11 months ago (2017-01-10 16:10:42 UTC) #5
stkhapugin
PTAL
3 years, 11 months ago (2017-01-10 16:13:06 UTC) #8
Olivier
lgtm
3 years, 11 months ago (2017-01-10 16:24:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627453003/20001
3 years, 11 months ago (2017-01-11 10:26:52 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 10:42:22 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7caec88b05daa5caec5c923ff60d...

Powered by Google App Engine
This is Rietveld 408576698