IDBObjectStore/IDBIndex.getAll/getAllKeys should have [EnforceRange]

IDBObjectStore/IDBIndex.getAll/getAllKeys should have [EnforceRange]

Per spec, the |count| argument for the getAll() and getAllKeys()
method should have the [EnforceRange] extended attribute which makes
the method throw if an invalid number or number out of range is passed
(e.g. not a number, infinity, negative, etc) rather than silently
coercing as is the default (for historical reasons).

Blink was just missing these attributes on three of the four methods.
Firefox has them. Added the attributes and test cases.

BUG=679465
R=pwnall@chromium.org

Review-Url: https://codereview.chromium.org/2627453002
Cr-Commit-Position: refs/heads/master@{#442419}
Committed: https://chromium.googlesource.com/chromium/src/+/99435bd5b9707422116b5aa06e4fc81adbeb34b7

[jsbell, 2017-01-09 21:19:38]

The CQ bit was checked by jsbell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 21:20:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jsbell, 2017-01-09 21:20:12]

pwnall@ - can you take a look?

Noticed this c/o https://github.com/w3c/IndexedDB/issues/131

(spec is fine, blink was just missing the attributes)

[pwnall, 2017-01-09 21:35:55]

LGTM.

Would you like me to upstream these tests after they land, and remove them when
they get imported?

[jsbell, 2017-01-09 22:13:40]

On 2017/01/09 21:35:55, pwnall wrote:
> Would you like me to upstream these tests after they land, and remove them
when
> they get imported?

Yes please - I added them to our spreadsheet already.

[commit-bot: I haz the power, 2017-01-09 23:30:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:30:15]

Dry run: This issue passed the CQ dry run.

[jsbell, 2017-01-09 23:39:28]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2017-01-09 23:40:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 00:28:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484005168170210, "parent_rev":
"61928d472633c41dacd44c8982cfa92bbc9e2d4e", "commit_rev":
"99435bd5b9707422116b5aa06e4fc81adbeb34b7"}

[commit-bot: I haz the power, 2017-01-10 00:29:22]

Description was changed from

==========
IDBObjectStore/IDBIndex.getAll/getAllKeys should have [EnforceRange]

Per spec, the |count| argument for the getAll() and getAllKeys()
method should have the [EnforceRange] extended attribute which makes
the method throw if an invalid number or number out of range is passed
(e.g. not a number, infinity, negative, etc) rather than silently
coercing as is the default (for historical reasons).

Blink was just missing these attributes on three of the four methods.
Firefox has them. Added the attributes and test cases.

BUG=679465
R=pwnall@chromium.org
==========

to

==========
IDBObjectStore/IDBIndex.getAll/getAllKeys should have [EnforceRange]

Per spec, the |count| argument for the getAll() and getAllKeys()
method should have the [EnforceRange] extended attribute which makes
the method throw if an invalid number or number out of range is passed
(e.g. not a number, infinity, negative, etc) rather than silently
coercing as is the default (for historical reasons).

Blink was just missing these attributes on three of the four methods.
Firefox has them. Added the attributes and test cases.

BUG=679465
R=pwnall@chromium.org

Review-Url: https://codereview.chromium.org/2627453002
Cr-Commit-Position: refs/heads/master@{#442419}
Committed:
https://chromium.googlesource.com/chromium/src/+/99435bd5b9707422116b5aa06e4f...
==========

[commit-bot: I haz the power, 2017-01-10 00:29:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99435bd5b9707422116b5aa06e4f...