Remove ScopedVector from remoting/.

Remove ScopedVector from remoting/.

BUG=554289
Review-Url: https://codereview.chromium.org/2627433003
Cr-Commit-Position: refs/heads/master@{#442928}
Committed: https://chromium.googlesource.com/chromium/src/+/954c9c1df7a0f467fe6e09a67d58e90e9bff7116

[Avi (use Gerrit), 2017-01-10 17:48:44]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 17:48:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 18:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 18:32:30]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-10 20:43:25]

avi@chromium.org changed reviewers:
+ wez@chromium.org

[Sergey Ulanov, 2017-01-10 21:24:54]

sergeyu@chromium.org changed reviewers:
+ sergeyu@chromium.org

[Sergey Ulanov, 2017-01-10 21:24:54]

lgtm when my nits are addressed

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
File remoting/host/host_extension_session_manager.h (right):

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
remoting/host/host_extension_session_manager.h:61: const HostExtensions&
extensions_;
It's better to make this a pointer (and pass a pointer in the constructor).
Reference fields are error-prone.

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
File remoting/host/host_extension_session_manager_unittest.cc (right):

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
remoting/host/host_extension_session_manager_unittest.cc:36: FakeExtension*
extension3_;
Please remove these 3 fields and update the tests to use extension_[i].

[Avi (use Gerrit), 2017-01-10 21:44:11]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-10 21:44:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 22:12:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-10 22:12:23]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-01-10 23:57:29]

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
File remoting/host/host_extension_session_manager.h (right):

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
remoting/host/host_extension_session_manager.h:61: const HostExtensions&
extensions_;
On 2017/01/10 21:24:54, Sergey Ulanov wrote:
> It's better to make this a pointer (and pass a pointer in the constructor).
> Reference fields are error-prone.

Switching to vector of raw pointers; it works better.

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
File remoting/host/host_extension_session_manager_unittest.cc (right):

https://codereview.chromium.org/2627433003/diff/1/remoting/host/host_extensio...
remoting/host/host_extension_session_manager_unittest.cc:36: FakeExtension*
extension3_;
On 2017/01/10 21:24:54, Sergey Ulanov wrote:
> Please remove these 3 fields and update the tests to use extension_[i].

Obviated.

[Sergey Ulanov, 2017-01-11 00:37:41]

lgtm

[Avi (use Gerrit), 2017-01-11 16:47:02]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2017-01-11 16:47:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 16:52:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484153222235810,
"parent_rev": "cc331493b0ed0d6bc3cba5499f1f51326199feae", "commit_rev":
"954c9c1df7a0f467fe6e09a67d58e90e9bff7116"}

[commit-bot: I haz the power, 2017-01-11 16:53:53]

Description was changed from

==========
Remove ScopedVector from remoting/.

BUG=554289
==========

to

==========
Remove ScopedVector from remoting/.

BUG=554289

Review-Url: https://codereview.chromium.org/2627433003
Cr-Commit-Position: refs/heads/master@{#442928}
Committed:
https://chromium.googlesource.com/chromium/src/+/954c9c1df7a0f467fe6e09a67d58...
==========

[commit-bot: I haz the power, 2017-01-11 16:53:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/954c9c1df7a0f467fe6e09a67d58...