Fix a findbugs warning - check file.mkdirs return value.

Fix a findbugs warning - check file.mkdirs return value.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268018

[Andrew Hayden (chromium.org), 2014-05-02 10:02:31]

https://codereview.chromium.org/262743003/diff/1/tools/binary_size/java/src/o...
File tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
(right):

https://codereview.chromium.org/262743003/diff/1/tools/binary_size/java/src/o...
tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java:102:
assert new File(mFailPath).getParentFile().mkdirs();
If the output directory already exists (which should not be an error), this
assert will trigger. In order to fix this properly I think we need:

File parentDir = new File(mFailPath).getParentFile();
assert (parentDir.mkdirs() || parentDir.isDirectory())

[vandebo (ex-Chrome), 2014-05-02 17:29:39]

https://codereview.chromium.org/262743003/diff/1/tools/binary_size/java/src/o...
File tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
(right):

https://codereview.chromium.org/262743003/diff/1/tools/binary_size/java/src/o...
tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java:102:
assert new File(mFailPath).getParentFile().mkdirs();
On 2014/05/02 10:02:31, Andrew Hayden wrote:
> If the output directory already exists (which should not be an error), this
> assert will trigger. In order to fix this properly I think we need:
> 
> File parentDir = new File(mFailPath).getParentFile();
> assert (parentDir.mkdirs() || parentDir.isDirectory())

Done.

[Andrew Hayden (chromium.org), 2014-05-02 17:43:20]

LGTM, thanks!

[vandebo (ex-Chrome), 2014-05-02 21:40:10]

The CQ bit was checked by vandebo@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:41:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vandebo@chromium.org/262743003/20001

[commit-bot: I haz the power, 2014-05-02 21:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:41:36]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[vandebo (ex-Chrome), 2014-05-02 21:45:51]

+thestig for "official" review

[Lei Zhang, 2014-05-02 21:46:54]

lgtm

[vandebo (ex-Chrome), 2014-05-02 21:47:18]

The CQ bit was unchecked by vandebo@chromium.org

[vandebo (ex-Chrome), 2014-05-02 21:47:19]

The CQ bit was checked by vandebo@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:47:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vandebo@chromium.org/262743003/20001

[commit-bot: I haz the power, 2014-05-02 21:47:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:47:53]

Failed to apply patch for build/android/findbugs_filter/findbugs_known_bugs.txt:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file build/android/findbugs_filter/findbugs_known_bugs.txt
  Hunk #1 FAILED at 33.
  1 out of 1 hunk FAILED -- saving rejects to file
build/android/findbugs_filter/findbugs_known_bugs.txt.rej

Patch:       build/android/findbugs_filter/findbugs_known_bugs.txt
Index: build/android/findbugs_filter/findbugs_known_bugs.txt
diff --git a/build/android/findbugs_filter/findbugs_known_bugs.txt
b/build/android/findbugs_filter/findbugs_known_bugs.txt
index
082a9e98b43484bfcd700b68dfa3ab7855fc52cb..a7a8a6222ea2954f6fd3161ea047ff4ca94e87a4
100644
--- a/build/android/findbugs_filter/findbugs_known_bugs.txt
+++ b/build/android/findbugs_filter/findbugs_known_bugs.txt
@@ -33,6 +33,5 @@ M V MS:
org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_INHERIT should be
 M V MS: org.chromium.content.browser.LoadUrlParams.UA_OVERRIDE_TRUE isn't final
and can't be protected from malicious code   In LoadUrlParams.java
 M M LI: Incorrect lazy initialization of static field
org.chromium.chrome.browser.sync.ProfileSyncService.sSyncSetupManager in
org.chromium.chrome.browser.sync.ProfileSyncService.get(Context)  At
ProfileSyncService.java
 M B OS:
org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run()
may fail to close stream  At Addr2LineWorkerPool.java
-M B RV: Exceptional return value of java.io.File.mkdirs() ignored in new
org.chromium.tools.binary_size.NmDumper$Output(NmDumper)  At NmDumper.java
 M C CSM: Shouldn't use synchronized method, please narrow down the
synchronization scope.  At NmDumper.java
 M D REC: Exception is caught when Exception is not thrown in
org.chromium.tools.binary_size.Addr2LineWorkerPool$Addr2LineWorker$Addr2LineTask.run()
 At Addr2LineWorkerPool.java

[vandebo (ex-Chrome), 2014-05-02 21:53:42]

The CQ bit was checked by vandebo@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:53:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vandebo@chromium.org/262743003/40001

[commit-bot: I haz the power, 2014-05-03 02:50:34]

Change committed as 268018