Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java

Issue 262743003: Fix a findbugs warning - check file.mkdirs return value. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/findbugs_filter/findbugs_known_bugs.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
diff --git a/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java b/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
index 286fd61bb9fd50838dffde6271806e1442a3270f..81b05fa1f3f61c3c2a05e5e6cf6a6c914f73db77 100644
--- a/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
+++ b/tools/binary_size/java/src/org/chromium/tools/binary_size/NmDumper.java
@@ -91,7 +91,8 @@ class NmDumper {
private Output() {
try {
- new File(mOutPath).getParentFile().mkdirs();
+ File parentDir = new File(mOutPath).getParentFile();
+ assert (parentDir.mkdirs() || parentDir.isDirectory());
outWriter = new PrintWriter(mOutPath);
} catch (FileNotFoundException e) {
throw new RuntimeException("Can't open output file: " + mOutPath, e);
@@ -99,7 +100,8 @@ class NmDumper {
if (mFailPath != null) {
try {
- new File(mFailPath).getParentFile().mkdirs();
+ File parentDir = new File(mFailPath).getParentFile();
+ assert (parentDir.mkdirs() || parentDir.isDirectory());
failWriter = new PrintWriter(mFailPath);
} catch (FileNotFoundException e) {
throw new RuntimeException("Can't open fail file: " + mFailPath, e);
@@ -110,7 +112,8 @@ class NmDumper {
if (mSkipPath != null) {
try {
- new File(mSkipPath).getParentFile().mkdirs();
+ File parentDir = new File(mSkipPath).getParentFile();
+ assert (parentDir.mkdirs() || parentDir.isDirectory());
skipWriter = new PrintWriter(mSkipPath);
} catch (IOException e) {
throw new RuntimeException("Can't open skip file: " + mSkipPath, e);
« no previous file with comments | « build/android/findbugs_filter/findbugs_known_bugs.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698