NavigatorContentUtils should be a supplement of Navigator

NavigatorContentUtils should be a supplement of Navigator

It looks strange that NavigatorContentUtils is a supplement of LocalFrame.
It should be a supplement of Navigator.

BUG=610176
Review-Url: https://codereview.chromium.org/2627413003
Cr-Commit-Position: refs/heads/master@{#443529}
Committed: https://chromium.googlesource.com/chromium/src/+/094e935d5c50ada3877c9ba4c29d3f8fef51093e

[haraken, 2017-01-13 07:26:59]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-13 07:27:00]

PTAL

[gyuyoung2, 2017-01-13 07:39:29]

On 2017/01/13 07:27:00, haraken wrote:
> PTAL

lgtm.

[sof, 2017-01-13 07:40:30]

https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h
(right):

https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h:67:
static void provideNavigatorContentUtilsTo(Navigator&,
rename to provideTo() ?

https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/ChromeClientImpl.cpp:1160:
*frame.domWindow()->navigator(),
this will now instantiate a Navigator earlier (and always), but i suppose it
isn't too heavy.

[haraken, 2017-01-13 08:04:31]

On 2017/01/13 07:40:30, sof wrote:
>
https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
> File
>
third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h
> (right):
> 
>
https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h:67:
> static void provideNavigatorContentUtilsTo(Navigator&,
> rename to provideTo() ?

Done.

> 
>
https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/web/ChromeClientImpl.cpp (right):
> 
>
https://codereview.chromium.org/2627413003/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/web/ChromeClientImpl.cpp:1160:
> *frame.domWindow()->navigator(),
> this will now instantiate a Navigator earlier (and always), but i suppose it
> isn't too heavy.

[sof, 2017-01-13 08:13:47]

lgtm

https://codereview.chromium.org/2627413003/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp
(right):

https://codereview.chromium.org/2627413003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp:244:
NavigatorContentUtils::provideTo(
Drop the NavigatorContentUtils:: namespace qualifiers?

[haraken, 2017-01-13 09:11:04]

The CQ bit was checked by haraken@chromium.org

[haraken, 2017-01-13 09:11:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
gyuyoung.kim@chromium.org, sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/2627413003/#ps60001
(title: "temp")

[commit-bot: I haz the power, 2017-01-13 09:11:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 10:59:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484298664916700,
"parent_rev": "71d04138368832f6649c3ca85b4384dadde2c640", "commit_rev":
"094e935d5c50ada3877c9ba4c29d3f8fef51093e"}

[commit-bot: I haz the power, 2017-01-13 10:59:48]

Description was changed from

==========
NavigatorContentUtils should be a supplement of Navigator

It looks strange that NavigatorContentUtils is a supplement of LocalFrame.
It should be a supplement of Navigator.

BUG=610176
==========

to

==========
NavigatorContentUtils should be a supplement of Navigator

It looks strange that NavigatorContentUtils is a supplement of LocalFrame.
It should be a supplement of Navigator.

BUG=610176

Review-Url: https://codereview.chromium.org/2627413003
Cr-Commit-Position: refs/heads/master@{#443529}
Committed:
https://chromium.googlesource.com/chromium/src/+/094e935d5c50ada3877c9ba4c29d...
==========

[commit-bot: I haz the power, 2017-01-13 10:59:49]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/094e935d5c50ada3877c9ba4c29d...