Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 2627403003: MD Settings: Scroll to top when navigating to About page. (Closed)

Created:
3 years, 11 months ago by tommycli
Modified:
3 years, 11 months ago
Reviewers:
dschuyler, Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Scroll to top when navigating to About page. BUG=667671 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2627403003 Cr-Commit-Position: refs/heads/master@{#444217} Committed: https://chromium.googlesource.com/chromium/src/+/52d38e7a5ae31b750d87205b072a324cf99926ef

Patch Set 1 #

Total comments: 4

Patch Set 2 : combine conditionals #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/test/data/webui/settings/basic_page_browsertest.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tommycli
dbeam: PTAL, thanks!
3 years, 11 months ago (2017-01-13 19:54:07 UTC) #3
tommycli
On 2017/01/13 19:54:07, tommycli wrote: > dbeam: PTAL, thanks! dbeam: ping, thanks!
3 years, 11 months ago (2017-01-17 22:25:24 UTC) #4
tommycli
dschuyler: PTAL, thanks!
3 years, 11 months ago (2017-01-17 23:07:23 UTC) #6
dschuyler
https://codereview.chromium.org/2627403003/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2627403003/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js#newcode51 chrome/browser/resources/settings/settings_page/main_page_behavior.js:51: // Always scroll to the top when navigating to ...
3 years, 11 months ago (2017-01-17 23:33:38 UTC) #7
tommycli
dschuyler: Thanks! I took the suggestion. https://codereview.chromium.org/2627403003/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/2627403003/diff/1/chrome/browser/resources/settings/settings_page/main_page_behavior.js#newcode51 chrome/browser/resources/settings/settings_page/main_page_behavior.js:51: // Always scroll ...
3 years, 11 months ago (2017-01-17 23:47:00 UTC) #8
dschuyler
lgtm
3 years, 11 months ago (2017-01-17 23:53:59 UTC) #9
tommycli
On 2017/01/17 23:53:59, dschuyler wrote: > lgtm thanks!
3 years, 11 months ago (2017-01-17 23:57:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2627403003/40001
3 years, 11 months ago (2017-01-17 23:57:53 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 01:04:13 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/52d38e7a5ae31b750d87205b072a...

Powered by Google App Engine
This is Rietveld 408576698