Replace std::map with std::pair for (origin, engagement) tuples in RenderFrameImpl.

Replace std::map with std::pair for (origin, engagement) tuples in RenderFrameImpl.

The engagement level should correspond to precisely one origin within
a frame. This CL replaces its map temporary storage variable with
a pair.

BUG=655415
Review-Url: https://codereview.chromium.org/2627393002
Cr-Commit-Position: refs/heads/master@{#444570}
Committed: https://chromium.googlesource.com/chromium/src/+/89fba275a0be24ab7a318f92f179f7c9495ccae0

[dominickn, 2017-01-13 02:21:01]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 02:21:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-01-13 02:21:49]

dominickn@chromium.org changed reviewers:
+ nasko@chromium.org

[dominickn, 2017-01-13 02:21:50]

PTAL, thanks! This seems to work just fine.

[commit-bot: I haz the power, 2017-01-13 04:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:12:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nasko, 2017-01-18 22:33:37]

I think this looks fine too. LGTM with one question.

https://codereview.chromium.org/2627393002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2627393002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:4798: engagement_level_.first =
url::Origin();
Should this be wiped out every time or just when we actually used it?

[dominickn, 2017-01-18 23:27:43]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 23:28:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 00:25:59]

Dry run: This issue passed the CQ dry run.

[dominickn, 2017-01-19 00:34:51]

Thanks!

https://codereview.chromium.org/2627393002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2627393002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:4798: engagement_level_.first =
url::Origin();
On 2017/01/18 22:33:37, nasko wrote:
> Should this be wiped out every time or just when we actually used it?

Good point. Changed to wipe only when we used it, I think that makes sense.

[dominickn, 2017-01-19 00:34:56]

The CQ bit was checked by dominickn@chromium.org

[dominickn, 2017-01-19 00:34:57]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/2627393002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2017-01-19 00:35:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:40:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484786096392810,
"parent_rev": "76487916dca57284cb33baa5a4260b3a1835628a", "commit_rev":
"38b53288e8a6cd007b4a9093c7b26758e4cccf3b"}

[commit-bot: I haz the power, 2017-01-19 00:44:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484786096392810,
"parent_rev": "e79d590e48fe32e1691b05d0fac27ebdd1f7c79e", "commit_rev":
"89fba275a0be24ab7a318f92f179f7c9495ccae0"}

[commit-bot: I haz the power, 2017-01-19 00:45:08]

Description was changed from

==========
Replace std::map with std::pair for (origin, engagement) tuples in
RenderFrameImpl.

The engagement level should correspond to precisely one origin within
a frame. This CL replaces its map temporary storage variable with
a pair.

BUG=655415
==========

to

==========
Replace std::map with std::pair for (origin, engagement) tuples in
RenderFrameImpl.

The engagement level should correspond to precisely one origin within
a frame. This CL replaces its map temporary storage variable with
a pair.

BUG=655415

Review-Url: https://codereview.chromium.org/2627393002
Cr-Commit-Position: refs/heads/master@{#444570}
Committed:
https://chromium.googlesource.com/chromium/src/+/89fba275a0be24ab7a318f92f179...
==========

[commit-bot: I haz the power, 2017-01-19 00:45:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/89fba275a0be24ab7a318f92f179...