MD History: Replace app-drawer with cr-drawer

MD History: Replace app-drawer with cr-drawer

This replaces the sidebar drawer in MD History with the shared cr-drawer
element. cr-drawer has several benefits over app-drawer:

* Styling is now directly shared with MD Settings
* Focus is now correctly trapped within the drawer when it is open
* cr-drawer is significantly smaller, saving 8kb of bundled page size
  (before gzip). Binary size will decrease further when we remove
  app-drawer in a follow-up CL.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627383002
Cr-Commit-Position: refs/heads/master@{#444257}
Committed: https://chromium.googlesource.com/chromium/src/+/e316eda37d7a3b330320fcad850dd62902123dd4

[tsergeant, 2017-01-13 02:20:48]

Description was changed from

==========
MD History: Replace app-drawer with cr-drawer

This replaces the sidebar drawer in MD History with the shared cr-drawer
element. cr-drawer has several benefits over app-drawer:

* Styling is now directly shared with MD Settings
* Focus is now correctly trapped within the drawer when it is open
* cr-drawer is significantly smaller, saving 8kb of bundled page size
  (before gzip). Binary size will decrease further when we remove
  app-drawer in a follow-up CL.

BUG=629808
==========

to

==========
MD History: Replace app-drawer with cr-drawer

This replaces the sidebar drawer in MD History with the shared cr-drawer
element. cr-drawer has several benefits over app-drawer:

* Styling is now directly shared with MD Settings
* Focus is now correctly trapped within the drawer when it is open
* cr-drawer is significantly smaller, saving 8kb of bundled page size
  (before gzip). Binary size will decrease further when we remove
  app-drawer in a follow-up CL.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-01-13 02:45:58]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 02:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 04:41:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 04:41:01]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-16 00:13:35]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 00:13:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-16 00:14:04]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-01-16 00:14:05]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-01-16 00:14:05]

Welcome back, have a code review

[tsergeant, 2017-01-16 00:14:05]

Welcome back, have a code review

[commit-bot: I haz the power, 2017-01-16 01:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 01:11:52]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-01-16 05:55:58]

Code LG, but the drawer close animation is a bit jank? Closing by clicking a
menu item has no animation and clicking off the menu removes the overlay
instantly which also looks off.

[tsergeant, 2017-01-16 06:18:51]

Whoops, yep. Was using the native dialog close() function rather than the
cr-drawer closeDrawer() function. This causes the animation to goof up the next
time you open it.

[tsergeant, 2017-01-16 08:05:32]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 08:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 09:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 09:59:40]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-18 00:50:32]

ping~

from talking in person, it sounds like you were happy with this (apart from the
backdrop animation)

[calamity, 2017-01-18 01:56:40]

I am. lgtm.

[tsergeant, 2017-01-18 01:58:12]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:58:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 03:07:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484704692846850,
"parent_rev": "9413cffb4fdc7dbcfc40a8da0530942e2f6ae0f2", "commit_rev":
"e316eda37d7a3b330320fcad850dd62902123dd4"}

[commit-bot: I haz the power, 2017-01-18 03:07:52]

Description was changed from

==========
MD History: Replace app-drawer with cr-drawer

This replaces the sidebar drawer in MD History with the shared cr-drawer
element. cr-drawer has several benefits over app-drawer:

* Styling is now directly shared with MD Settings
* Focus is now correctly trapped within the drawer when it is open
* cr-drawer is significantly smaller, saving 8kb of bundled page size
  (before gzip). Binary size will decrease further when we remove
  app-drawer in a follow-up CL.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Replace app-drawer with cr-drawer

This replaces the sidebar drawer in MD History with the shared cr-drawer
element. cr-drawer has several benefits over app-drawer:

* Styling is now directly shared with MD Settings
* Focus is now correctly trapped within the drawer when it is open
* cr-drawer is significantly smaller, saving 8kb of bundled page size
  (before gzip). Binary size will decrease further when we remove
  app-drawer in a follow-up CL.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627383002
Cr-Commit-Position: refs/heads/master@{#444257}
Committed:
https://chromium.googlesource.com/chromium/src/+/e316eda37d7a3b330320fcad850d...
==========

[commit-bot: I haz the power, 2017-01-18 03:07:53]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e316eda37d7a3b330320fcad850d...