Enabling new FRE and launch flow by default on Win 10.

Enabling new FRE and launch flow by default on Win 10.

BUG=680774
Review-Url: https://codereview.chromium.org/2627363002
Cr-Commit-Position: refs/heads/master@{#447608}
Committed: https://chromium.googlesource.com/chromium/src/+/f9a9ef14dfdb45e70a898024b5c690ac4bf3a5e0

[tmartino, 2017-01-12 23:28:44]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:29:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-01-12 23:35:24]

The CQ bit was unchecked by tmartino@chromium.org

[tmartino, 2017-01-12 23:35:39]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 23:35:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 00:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 00:07:42]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[tmartino, 2017-01-16 18:32:15]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 18:32:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 19:17:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 19:17:32]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-01-27 20:23:58]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 20:24:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 20:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 20:37:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tmartino, 2017-01-27 20:46:01]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 20:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-01-27 21:05:32]

The CQ bit was unchecked by tmartino@chromium.org

[tmartino, 2017-01-27 22:42:20]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 22:43:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 23:31:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 23:31:25]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-01-30 16:19:36]

tmartino@chromium.org changed reviewers:
+ pastarmovj@chromium.org, pkasting@chromium.org

[tmartino, 2017-01-30 16:19:38]

+pkasting for OWNERS on c/b/ui
+pastarmovj for OWNERS on c/b/policy

[pastarmovj, 2017-01-31 07:07:49]

policy lgtm

[Peter Kasting, 2017-02-01 02:09:51]

LGTM

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc (right):

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:243: #endif
Lots of places in this file, and one place in another file in this CL, have this
block.

It seems like it would be nice to do something like:

namespace {  // Or maybe in a common utility file both test files can call

// Disables the welcome pages for all |profiles|, as well as the Win 10 promo
// page (if applicable).
void DisableWelcomePages(const std::vector<Profile*>& profiles) {
  for (Profile* profile : profiles)
    profile->GetPrefs()->SetBoolean(prefs::kHasSeenWelcomePage, true);

#if defined(OS_WIN)
  g_browser_process->local_state()->SetBoolean(prefs::kHasSeenWin10PromoPage,
                                               true);
#endif
}

}

...

  DisableWelcomePages({profile1, profile2});

This ensures tests that want to disable welcome pages similarly disable the Win
10 promo page, and reduces code duplication as well.

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right):

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
chrome/browser/ui/startup/startup_browser_creator_impl.cc:287: //
TODO(tmartino): Add a Win10+ specific experiment.
Is this TODO still unimplemented?

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
File chrome/browser/ui/startup/startup_features.cc (right):

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
chrome/browser/ui/startup/startup_features.cc:17: "WelcomeWin10InlineStyle",
base::FEATURE_ENABLED_BY_DEFAULT};
Nit: Did git cl format change the wrapping here?  I kinda thought the old
wrapping was better, but not enough to try and override git cl format

[tmartino, 2017-02-01 19:44:45]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 19:45:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tmartino, 2017-02-01 20:10:31]

The CQ bit was checked by tmartino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 20:11:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 21:02:56]

Dry run: This issue passed the CQ dry run.

[tmartino, 2017-02-01 21:04:33]

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
File chrome/browser/ui/startup/startup_browser_creator_browsertest.cc (right):

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
chrome/browser/ui/startup/startup_browser_creator_browsertest.cc:243: #endif
On 2017/02/01 at 02:09:51, Peter Kasting wrote:
> Lots of places in this file, and one place in another file in this CL, have
this block.
> 
> It seems like it would be nice to do something like:
> 
> namespace {  // Or maybe in a common utility file both test files can call
> 
> // Disables the welcome pages for all |profiles|, as well as the Win 10 promo
> // page (if applicable).
> void DisableWelcomePages(const std::vector<Profile*>& profiles) {
>   for (Profile* profile : profiles)
>     profile->GetPrefs()->SetBoolean(prefs::kHasSeenWelcomePage, true);
> 
> #if defined(OS_WIN)
>   g_browser_process->local_state()->SetBoolean(prefs::kHasSeenWin10PromoPage,
>                                                true);
> #endif
> }
> 
> }
> 
> ...
> 
>   DisableWelcomePages({profile1, profile2});
> 
> This ensures tests that want to disable welcome pages similarly disable the
Win 10 promo page, and reduces code duplication as well.

Done

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
File chrome/browser/ui/startup/startup_browser_creator_impl.cc (right):

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
chrome/browser/ui/startup/startup_browser_creator_impl.cc:287: //
TODO(tmartino): Add a Win10+ specific experiment.
On 2017/02/01 at 02:09:51, Peter Kasting wrote:
> Is this TODO still unimplemented?

Whoops, no. This change resolves it.

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
File chrome/browser/ui/startup/startup_features.cc (right):

https://codereview.chromium.org/2627363002/diff/180001/chrome/browser/ui/star...
chrome/browser/ui/startup/startup_features.cc:17: "WelcomeWin10InlineStyle",
base::FEATURE_ENABLED_BY_DEFAULT};
On 2017/02/01 at 02:09:51, Peter Kasting wrote:
> Nit: Did git cl format change the wrapping here?  I kinda thought the old
wrapping was better, but not enough to try and override git cl format

Yeah, this was git cl format.

[tmartino, 2017-02-01 21:04:39]

The CQ bit was checked by tmartino@chromium.org

[tmartino, 2017-02-01 21:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2627363002/#ps220001
(title: "ChromeOS Unused Function")

[commit-bot: I haz the power, 2017-02-01 21:05:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:11:11]

CQ is committing da patch.

Bot data: {"patchset_id": 220001, "attempt_start_ts": 1485983079648110,
"parent_rev": "e027f6a77853952285de14c8b9009c208b4c2c99", "commit_rev":
"f9a9ef14dfdb45e70a898024b5c690ac4bf3a5e0"}

[commit-bot: I haz the power, 2017-02-01 21:11:45]

Description was changed from

==========
Enabling new FRE and launch flow by default on Win 10.

BUG=680774
==========

to

==========
Enabling new FRE and launch flow by default on Win 10.

BUG=680774

Review-Url: https://codereview.chromium.org/2627363002
Cr-Commit-Position: refs/heads/master@{#447608}
Committed:
https://chromium.googlesource.com/chromium/src/+/f9a9ef14dfdb45e70a898024b5c6...
==========

[commit-bot: I haz the power, 2017-02-01 21:11:47]

Committed patchset #12 (id:220001) as
https://chromium.googlesource.com/chromium/src/+/f9a9ef14dfdb45e70a898024b5c6...