Settings/Oobe: Simplify cr-network-select and use flex

Settings/Oobe: Simplify cr-network-select and use flex

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627353003
Cr-Commit-Position: refs/heads/master@{#443466}
Committed: https://chromium.googlesource.com/chromium/src/+/18f57643956afd97ed6024ff8e499f917b36fe61

[stevenjb, 2017-01-12 22:38:38]

Description was changed from

==========
Settings/Oobe: Simplify cr-network-select and use flex

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
==========

to

==========
Settings/Oobe: Simplify cr-network-select and use flex

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-01-12 22:44:52]

stevenjb@chromium.org changed reviewers:
+ alemate@chromium.org

[Alexander Alekseev, 2017-01-12 23:10:09]

lgtm

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (left):

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:201: max-height="307">
Thank you for this!

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:139: if
(this.networkSelectionScreenShown) {
Is this to fix "some of the network entries are not rendered after element was
shown until the 'refresh networks' event is triggered"?

This still looks like a bug in Polymer. Should we add a note on that here?

[stevenjb, 2017-01-13 00:03:14]

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.html (left):

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.html:201: max-height="307">
On 2017/01/12 23:10:09, Alexander Alekseev wrote:
> Thank you for this!

You're welcome :) That was a terrible hack.

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2627353003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/oobe_welcome.js:139: if
(this.networkSelectionScreenShown) {
On 2017/01/12 23:10:09, Alexander Alekseev wrote:
> Is this to fix "some of the network entries are not rendered after element was
> shown until the 'refresh networks' event is triggered"?
> 
> This still looks like a bug in Polymer. Should we add a note on that here?

It's kind of a bug. The problem is, there is no DOM event to notify an element
when it is stamped. Since the element starts off hidden, we need to notify it
manually. It also makes sense to trigger a fresh network scan (e.g. in case the
user lingered on the first welcome screen), so this kills two birds with one
stone.

I added a comment.

[stevenjb, 2017-01-13 00:03:19]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-01-13 00:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from alemate@chromium.org
Link to the patchset: https://codereview.chromium.org/2627353003/#ps40001
(title: "Add comment")

[commit-bot: I haz the power, 2017-01-13 00:04:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 02:16:42]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484265799355450,
"parent_rev": "feda9ca742d2220f0da0d81e17f51a4917375405", "commit_rev":
"18f57643956afd97ed6024ff8e499f917b36fe61"}

[commit-bot: I haz the power, 2017-01-13 02:17:09]

Description was changed from

==========
Settings/Oobe: Simplify cr-network-select and use flex

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings/Oobe: Simplify cr-network-select and use flex

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627353003
Cr-Commit-Position: refs/heads/master@{#443466}
Committed:
https://chromium.googlesource.com/chromium/src/+/18f57643956afd97ed6024ff8e49...
==========

[commit-bot: I haz the power, 2017-01-13 02:17:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/18f57643956afd97ed6024ff8e49...